extend list of supported mimetypes for embedded image extractor
ClosedPublic

Authored by astippich on Tue, Dec 4, 7:27 PM.

Details

Summary

use existing functions to add support for new
mimetypes wav, aiff, ape, wavpack and speex

Test Plan

tests pass

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Tue, Dec 4, 7:27 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptTue, Dec 4, 7:27 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Tue, Dec 4, 7:27 PM
bruns accepted this revision.Tue, Dec 4, 11:38 PM

Can you mention the file types and their corresponding mimetypes in the Summary? Thx.

src/embeddedimagedata.cpp
199

Comment about tag->isEmpty() from D16671 applies here as well

This revision is now accepted and ready to land.Tue, Dec 4, 11:38 PM
astippich edited the summary of this revision. (Show Details)Thu, Dec 6, 6:09 PM
This revision was automatically updated to reflect the committed changes.