Differential D17358

implement cover extraction for asf files
ClosedPublic
Actions

Authored by astippich on Dec 4 2018, 7:30 PM.

Tags

Subscribers

kde-frameworks-devel, Baloo

Details

Reviewers

bruns
mgallien

Commits

R286:2a41e4b45262: implement cover extraction for asf files

Summary

implement support for last missing mimetype
compared to tagllibextractor

Test Plan

test passes

Diff Detail

Repository

R286 KFileMetaData

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich created this revision.Dec 4 2018, 7:30 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 4 2018, 7:30 PM

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Dec 4 2018, 7:30 PM

Harbormaster completed remote builds in B5702: Diff 46863.Dec 4 2018, 7:30 PM

astippich added a dependency: D17357: extend list of supported mimetypes for embedded image extractor.Dec 4 2018, 7:52 PM

fix

Harbormaster completed remote builds in B5705: Diff 46868.Dec 4 2018, 7:54 PM

bruns accepted this revision.Dec 4 2018, 11:43 PM

bruns added inline comments.

src/embeddedimagedata.cpp
278	Nitpick - empty line between functions

This revision is now accepted and ready to land.Dec 4 2018, 11:43 PM

Closed by commit R286:2a41e4b45262: implement cover extraction for asf files (authored by astippich). · Explain WhyDec 6 2018, 6:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/embeddedimagedatatest.cpp (4 lines)
M		(bin)	autotests/samplefiles/test.wma
M			src/embeddedimagedata.cpp (26 lines)

Diff 46985

autotests/embeddedimagedatatest.cpp

Loading...

autotests/samplefiles/test.wma

Loading...

src/embeddedimagedata.cpp

Loading...