Enable sharing URLs via email
ClosedPublic

Authored by nicolasfella on Dec 1 2018, 7:31 PM.

Details

Summary

Share URLs via email. Add title to input data
Depends on D17285

Test Plan

Send page via Email from Falkon

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 1 2018, 7:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 1 2018, 7:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 1 2018, 7:31 PM

I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client?

In D17287#370993, @apol wrote:

I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client?

The user still can change/remove it in the email client

apol accepted this revision.Fri, Feb 8, 10:42 PM
This revision is now accepted and ready to land.Fri, Feb 8, 10:42 PM
This revision was automatically updated to reflect the committed changes.