Differential D17287

Enable sharing URLs via email
ClosedPublic
Actions

Authored by nicolasfella on Dec 1 2018, 7:31 PM.

Details

Reviewers
apol
Commits
R495:73ea50ef1af2: Enable sharing URLs via email
Summary

Share URLs via email. Add title to input data
Depends on D17285

Test Plan

Send page via Email from Falkon

Diff Detail

Repository
R495 Purpose Library
Branch
emailUrl
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5589
Build 5607: arc lint + arc unit
nicolasfella created this revision.Dec 1 2018, 7:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 1 2018, 7:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 1 2018, 7:31 PM
apol added a comment.Dec 4 2018, 2:40 AM

I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client?

nicolasfella added a comment.Dec 10 2018, 12:27 AM
In D17287#370993, @apol wrote:

I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client?

The user still can change/remove it in the email client

apol accepted this revision.Feb 8 2019, 10:42 PM
This revision is now accepted and ready to land.Feb 8 2019, 10:42 PM
Closed by commit R495:73ea50ef1af2: Enable sharing URLs via email (authored by nicolasfella). · Explain WhyFeb 8 2019, 11:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46639

View Options

src/plugins/ShareUrlPluginType.json

Loading...
View Options

src/plugins/email/emailplugin.cpp

Loading...
View Options

src/plugins/email/emailplugin.json

Loading...