Enable page sharing
ClosedPublic

Authored by nicolasfella on Dec 1 2018, 6:25 PM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R875:7bca744cabb2: Enable page sharing
Summary

Use the new ShareUrl support from Purpose to share pages. ATM only sending the page via KDE Connect and Email is supported, but more can be added easily by extending Purpose.

Depends on D17285
Bug: 393543

Test Plan

Send page to phone via KDE Connect

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 1 2018, 6:25 PM
Restricted Application added a project: Falkon. · View Herald TranscriptDec 1 2018, 6:25 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
nicolasfella requested review of this revision.Dec 1 2018, 6:25 PM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella edited the summary of this revision. (Show Details)Dec 1 2018, 6:29 PM
  • Include page title
nicolasfella edited the summary of this revision. (Show Details)Dec 1 2018, 7:33 PM
  • Set correct min KF5
  • Remove unneeded include
drosca added a subscriber: drosca.Dec 2 2018, 10:08 AM

Looks good, but please use KDE/KF5 coding style - QMenu *menu.

src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp
43

Can you pass this as parent, otherwise it leaks.

  • Address comments
drosca accepted this revision.Dec 2 2018, 12:35 PM
drosca added inline comments.
src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.h
45

Menuc typo?

This revision is now accepted and ready to land.Dec 2 2018, 12:35 PM
nicolasfella marked an inline comment as done.Dec 2 2018, 12:38 PM
This revision was automatically updated to reflect the committed changes.