[SMS App] Allow passing a message via args
Needs ReviewPublic

Authored by nicolasfella on Sun, Dec 2, 1:02 AM.

Details

Reviewers
None
Group Reviewers
KDE Connect
Summary

Add --message option to kdeconnect-sms to pass a message. The user only needs to choose a recepient and the message will be sent. Useful for integration with 3rd party
apps, e.g. via Purpose

Test Plan

kdeconnect-sms --message "Hello World", choose chat, message is sent
Click another chat, no message sent
kdeconnect-sms without args, no message sent

Diff Detail

Repository
R224 KDE Connect
Branch
sendsms
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5602
Build 5620: arc lint + arc unit
nicolasfella created this revision.Sun, Dec 2, 1:02 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSun, Dec 2, 1:02 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Sun, Dec 2, 1:02 AM
apol added a subscriber: apol.Mon, Dec 3, 12:23 PM

Maybe instead of weirdly propagating an initial message it would make sense to have a sendMessage function?

sredman added a subscriber: sredman.Thu, Dec 6, 9:11 PM

I like the idea! It is very slick

  • It works for me
  • I think the operation should be cancel-able, maybe with an 'X' button on the InlineMessage banner to the right of "Choose recipient"
  • I think it would be better to not auto-send the message, but just populate the text box and leaving the user to push "Send" as a kind of confirmation. I click wrong buttons all the time, I would like a chance to double-check, especially in this case where there is no undo and potentially real-money cost.
smsapp/qml/ConversationList.qml
37

Spelling mistake: "Choose recipient"

I think it would be better to not auto-send the message...

I'd second that as a good idea. We use a similar mechanism in GSConnect when sharing links from the browser extension, but also to support sms: scheme handlers which can have a "body" field. If you were ever to support sms: scheme handlers it could be a reasonable security risk.