Hmm hmm. The goal of this was to behave like "du" as much as possible. As you say, the real bug isn't that we count directories, but that we count files "as is" instead of blocks. But I'm not sure how easily we could get block information from here.

(sure it's convenient for the unittest, but less meaningful for the users....)

With UFS, stat(1) tells me

[adridg@beastie .../kio/build]$ stat .
2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 131072 17 0x800 .

So that's a size of 17 -- on UFS that looks like the count of the files in the directory (I added a file and then size is 18).

Without this patch: jobtest has 71 tests, all pass.
With this patch: jobtest has 71 tests, all pass.

(Note that I ran the test against Frameworks 5.51, since I don't have 5.52 installed yet)

What's blocking here to merge this in Master?

I don't object to the patch, but maybe the properties dialog (and other users of this job) should indicate that the number being shown is "sum of file sizes, not actual disk space usage, which is larger" (blocks, inodes, directory sizes...)

In D17071#461613, @dfaure wrote:

I don't object to the patch, but maybe the properties dialog (and other users of this job) should indicate that the number being shown is "sum of file sizes, not actual disk space usage, which is larger" (blocks, inodes, directory sizes...)

or smaller - compression, deduplication ...

Well, this patch can still go in then, it makes one of the two values correct :-)

@davidedmundson any reference or version when you plan to make this "live"?

You created the patch within hours, it was approved within days.

One year later we still have nothing within master or any usable distro. Any plans at all to show correct file sizes with KDE?