This uses the new known_hosts API and creates SHA256 fingerprints for
public key verifcation.
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
This uses the new known_hosts API and creates SHA256 fingerprints for
public key verifcation.
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I've did a copy and paste of this, as libssh 0.8 is the way forward and the non 0.8 code should just be removed as soon as possible. In order to address a lot of issues, one needs to use libssh 0.8.
The size of the ifdef (and the therein contained code copy) isn't making me super excited. OTOH there are some 10 or 20 differences between the two if-branches, so separating it into multiple ifdefs is likely a mess as well. And @asn pointed out that doing it this way makes it easier to drop the legacy branch in the future.
Anyone got ideas how to make it better?
I am somewhat 'meh' about the ifdef but not enough to object, so in the absence of improvement suggests I'd probably go +1
Agreed, in this case I think the code duplication actually makes future cleanup easier. Let's go for it.