For working with D16129
- Create property "bedSize" in 3d View
- Adjust this whenever:
- Current Instance connects to a printer
- Current Instance changed.
For working with D16129
No Linters Available |
No Unit Test Coverage |
Buildable 3907 | |
Build 3925: arc lint + arc unit |
src/widgets/3dview/viewer3d.cpp | ||
---|---|---|
84–86 | you are setting the betsize? |
src/widgets/3dview/viewer3d.cpp | ||
---|---|---|
84–86 | You got two options here I'd say:
I don't see any real alternatives, it depends in which direction you want the dependency to go. |
you store the new dimensions in the Viewer3D here and you replace the implementation of BedProperties so that its instances find their Viewer3D and read the dimensions from there.
Can you modify your patch for this that seams more sane since the 3dView is what the main application interacts with already
I can try, which way would be best to get back to the View3D I belong to? (didn't check yet but from your patch you might have an idea already)
Plan to add the bedsize for delta printers.
src/widgets/atcoreinstancewidget.cpp | ||
---|---|---|
237 | Add Check if delta. } else { //Delta machines have only a radius. QSize newSize = QSize(m_profileData["radius"].toInt(), 0); } if (newSize != m_bedSize) { | |
580 | Add Delta Sizes , {"radius", m_settings.value(QStringLiteral("radius"), QStringLiteral("200"))} , {"z_delta_dimension", m_settings.value(QStringLiteral("z_delta_dimension"), QStringLiteral("180"))} |