leandrosantiago (Leandro Santiago)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 2 2016, 9:58 PM (123 w, 5 d)
Availability
Available

Recent Activity

Aug 18 2018

leandrosantiago added inline comments to D14891: fix potentially bug on accessing global variable on instance of AtCore.
Aug 18 2018, 8:41 AM
leandrosantiago updated the diff for D14891: fix potentially bug on accessing global variable on instance of AtCore.

Make type explicit on enum -> string conversion

Aug 18 2018, 8:38 AM

Aug 17 2018

leandrosantiago added inline comments to D14891: fix potentially bug on accessing global variable on instance of AtCore.
Aug 17 2018, 7:04 PM
leandrosantiago updated the diff for D14891: fix potentially bug on accessing global variable on instance of AtCore.

Use QtMetaEnum to generate the string from the axis.

Aug 17 2018, 7:01 PM
leandrosantiago abandoned D14906: Fix potentially bug on accessing global variable on instance of AtCore.

Revision created by mistake.

Aug 17 2018, 7:00 PM
leandrosantiago requested review of D14906: Fix potentially bug on accessing global variable on instance of AtCore.
Aug 17 2018, 6:58 PM
leandrosantiago added a comment to D14891: fix potentially bug on accessing global variable on instance of AtCore.

It seams that the user would need to be calling this function at the same time on more then one instance. How likely is that to happen? How do you feel about the code below? It removes the need for that variable all together. and removes the default case that will never be called.

Just imagine someone (like that eccentric rich cousin that everyone has :-)) using atcore to implement a client that is able to print to several printers at the same time. In order to AtCore to be used as a library, it needs to make no (or at least as few as possible) assumptions about how it is used (or at least document that it should not be used to control multiple printers).

void AtCore::move(AtCore::AXES axis, int arg)
{
    switch (axis) {
    case AtCore::X:
        move(QLatin1Char('X'), arg);
        break;
    case AtCore::Y:
        move(QLatin1Char('Y'), arg);
        break;
    case AtCore::Z:
        move(QLatin1Char('Z'), arg);
        break;
    case AtCore::E:
        move(QLatin1Char('E'), arg);
        break;
    };
}
Aug 17 2018, 7:17 AM

Aug 16 2018

leandrosantiago added reviewers for D14891: fix potentially bug on accessing global variable on instance of AtCore: Atelier: AtCore, Atelier.
Aug 16 2018, 8:30 PM
leandrosantiago requested review of D14891: fix potentially bug on accessing global variable on instance of AtCore.
Aug 16 2018, 8:27 PM

Jul 22 2018

leandrosantiago added a member for Atelier: AtCore: leandrosantiago.
Jul 22 2018, 1:21 PM

Jul 2 2018

leandrosantiago added a reviewer for D13859: Hide private implementation classes in order to prevent symbol collision: Atelier: AtCore.
Jul 2 2018, 8:31 PM
leandrosantiago updated the summary of D13859: Hide private implementation classes in order to prevent symbol collision.
Jul 2 2018, 8:25 PM
leandrosantiago requested review of D13859: Hide private implementation classes in order to prevent symbol collision.
Jul 2 2018, 8:24 PM

Sep 3 2016

leandrosantiago added a comment to D2643: Fix constant crashes related to the vi command bar.

Please use leandrosansilva@gmail.com

Sep 3 2016, 3:27 PM
leandrosantiago added a comment to D2643: Fix constant crashes related to the vi command bar.

@dhaumann, no, I don't have commit rights. Please commit it for me.

Sep 3 2016, 10:09 AM

Sep 2 2016

leandrosantiago retitled D2643: Fix constant crashes related to the vi command bar from to Fix constant crashes related to the vi command bar.
Sep 2 2016, 10:24 PM