Send bedSize to 3dviewer
ClosedPublic

Authored by rizzitello on Oct 11 2018, 10:53 PM.

Details

Summary

For working with D16129

  • Create property "bedSize" in 3d View
  • Adjust this whenever:
    1. Current Instance connects to a printer
    2. Current Instance changed.

Diff Detail

Repository
R231 Atelier
Branch
connectBedSize
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3926
Build 3944: arc lint + arc unit
rizzitello requested review of this revision.Oct 11 2018, 10:53 PM
rizzitello created this revision.
  • Update bed when atcore instance changes size
  • remove empty lines
tcanabrava requested changes to this revision.Oct 12 2018, 3:15 PM
tcanabrava added inline comments.
src/widgets/3dview/viewer3d.cpp
84–86

you are setting the betsize?

This revision now requires changes to proceed.Oct 12 2018, 3:15 PM
rizzitello added inline comments.Oct 12 2018, 3:19 PM
src/widgets/3dview/viewer3d.cpp
84–86

This is ment to work with D16129. I'm not sure how the bed properties is working to go further atm.

ervin added inline comments.Oct 13 2018, 9:24 AM
src/widgets/3dview/viewer3d.cpp
84–86

You got two options here I'd say:

  1. you add private API to BedProperties to change its size and you introspect the scene to find all BedProperties instances to overwrite the properties in them using said private API;
  2. you store the new dimensions in the Viewer3D here and you replace the implementation of BedProperties so that its instances find their Viewer3D and read the dimensions from there.

I don't see any real alternatives, it depends in which direction you want the dependency to go.

you store the new dimensions in the Viewer3D here and you replace the implementation of BedProperties so that its instances find their Viewer3D and read the dimensions from there.

Can you modify your patch for this that seams more sane since the 3dView is what the main application interacts with already

I can try, which way would be best to get back to the View3D I belong to? (didn't check yet but from your patch you might have an idea already)

I can try, which way would be best to get back to the View3D I belong to? (didn't check yet but from your patch you might have an idea already)

Im not sure how exactly todo that maybe @patrickelectric can help here.

rizzitello updated this revision to Diff 43664.Oct 15 2018, 4:18 PM
  • finalize (hopefully)
rizzitello updated this revision to Diff 43665.Oct 15 2018, 4:18 PM

remvoe debug line

rizzitello updated this revision to Diff 43666.Oct 15 2018, 4:19 PM

fix property typo

rizzitello edited the summary of this revision. (Show Details)Oct 15 2018, 4:28 PM
rizzitello updated this revision to Diff 43671.Oct 15 2018, 4:50 PM
rizzitello edited the summary of this revision. (Show Details)
  • cleaner functions , added ref use in lambda
tcanabrava accepted this revision.Oct 16 2018, 11:33 AM
This revision is now accepted and ready to land.Oct 16 2018, 11:33 AM
rizzitello planned changes to this revision.Oct 22 2018, 11:30 AM

Plan to add the bedsize for delta printers.

src/widgets/atcoreinstancewidget.cpp
237

Add Check if delta.

} else {
   //Delta machines have only a radius. 
    QSize newSize = QSize(m_profileData["radius"].toInt(), 0);
}

if (newSize != m_bedSize) {
580

Add Delta Sizes

, {"radius", m_settings.value(QStringLiteral("radius"), QStringLiteral("200"))}
, {"z_delta_dimension", m_settings.value(QStringLiteral("z_delta_dimension"), QStringLiteral("180"))}
rizzitello updated this revision to Diff 44084.Oct 22 2018, 7:52 PM
  • pull delta size data
This revision is now accepted and ready to land.Oct 22 2018, 7:52 PM
laysrodrigues accepted this revision.Oct 24 2018, 10:07 PM
rizzitello closed this revision.Oct 24 2018, 10:44 PM