Differential D16071

Use input field from Kaidan
ClosedPublic
Actions

Authored by nicolasfella on Oct 9 2018, 12:38 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:906cdfba6461: Use input field from Kaidan
Summary

It looks a bit better

Test Plan

Diff Detail

Repository
R224 KDE Connect
Branch
foo
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9405
Build 9423: arc lint + arc unit
nicolasfella created this revision.Oct 9 2018, 12:38 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 9 2018, 12:38 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Oct 9 2018, 12:38 PM
nicolasfella edited the test plan for this revision. (Show Details)Oct 9 2018, 12:40 PM
apol added a subscriber: apol.Oct 10 2018, 2:23 PM

Would it be possible to get this through Kirigami?

nicolasfella added a comment.Oct 20 2018, 2:51 PM
In D16071#340670, @apol wrote:

Would it be possible to get this through Kirigami?

What exactly? I don't think that an input field + send button is something suitable to include in Kirigami

apol added a subscriber: hein.Oct 22 2018, 10:04 PM

I don't see why not, if both KDE Connect and Kaidan need it...

I actually would expect Konversation to need it too. What do you do there @hein?

nicolasfella added a subscriber: mart.Oct 23 2018, 11:58 PM

@mart what do you think about this?

nicolasfella added a comment.Jan 24 2019, 9:14 AM

Ping? Even if we merge it now we could still move it to Kirigami at some point

sredman added a subscriber: sredman.Jan 24 2019, 5:47 PM

I don't have a problem with this. Like you say, if the future gives us what we need, we can change then. Of course, this patch will take a little bit of effort to rebase since lots of things around the text field have changed :/

albertvaka accepted this revision.Jan 25 2019, 12:30 PM
albertvaka added a subscriber: albertvaka.

Approving to unlock this, but if we want to put this in Kirigami so it is shared with other projects someone needs to take the ownership to make it happen. Otherwise it's difficult it gets done.

This revision is now accepted and ready to land.Jan 25 2019, 12:30 PM
nicolasfella closed this revision.Mar 9 2019, 11:36 PM
nicolasfella reopened this revision.Mar 10 2019, 12:08 AM
This revision is now accepted and ready to land.Mar 10 2019, 12:08 AM
nicolasfella closed this revision.Mar 10 2019, 1:39 AM

Revision Contents
Changeset List

PathPackages
Msmsapp/qml/ConversationDisplay.qml (85 lines)

Diff 53553

View Options

smsapp/qml/ConversationDisplay.qml

Loading...