Improve logout screen button appearance and contrast

Authored by ngraham on Oct 8 2018, 4:21 AM.


Group Reviewers

The logout screen buttons currently lack contrast and adequate difference between selected vs unselected states. This patch fixes those problems using the new icons from D15999 and the text shadows from D16031

BUG: 393048
FIXED-IN: 5.15.0

Depends on D16031

Test Plan

Note: A new version of the Back icon is missing because it has not yet been added to D15999. This will be corrected sometime in the next few days.

Diff Detail

logout-screen-button-improvements (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 3625
Build 3643: arc lint + arc unit
ngraham requested review of this revision.Oct 8 2018, 4:21 AM
ngraham created this revision.
ngraham edited the summary of this revision. (Show Details)Oct 8 2018, 4:22 AM
ngraham edited the test plan for this revision. (Show Details)
ngraham set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 8 2018, 4:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Nov 23 2018, 2:15 PM
mart added inline comments.

I would have preferred to not have new icons with a translucent circle behind, but rather doing such circle in QML

mart requested changes to this revision.Nov 23 2018, 2:16 PM
This revision now requires changes to proceed.Nov 23 2018, 2:16 PM
ngraham added inline comments.Nov 23 2018, 5:52 PM

This was discussed endlessly in T9658 and we couldn't find a good way to do it without the result looking really chunky and ugly. I'm open to a batter way to do it if you have some suggestions, though.


I mean T9444

ngraham abandoned this revision.Mar 2 2019, 9:33 PM

We're going in another direction with this.