Improve logout screen button appearance and contrast
AbandonedPublic
Actions

Authored by ngraham on Oct 8 2018, 4:21 AM.

Details

Reviewers

Group Reviewers

VDG
Plasma

Summary

The logout screen buttons currently lack contrast and adequate difference between selected vs unselected states. This patch fixes those problems using the new icons from D15999 and the text shadows from D16031

BUG: 393048
FIXED-IN: 5.15.0

Depends on D16031

Test Plan

Note: A new version of the Back icon is missing because it has not yet been added to D15999. This will be corrected sometime in the next few days.

Diff Detail

Branch

logout-screen-button-improvements (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3625
Build 3643: arc lint + arc unit

ngraham requested review of this revision.Oct 8 2018, 4:21 AM

ngraham created this revision.

Harbormaster completed remote builds in B3625: Diff 43100.Oct 8 2018, 4:21 AM

ngraham edited the summary of this revision. (Show Details)Oct 8 2018, 4:22 AM

ngraham edited the test plan for this revision. (Show Details)

ngraham set the repository for this revision to R120 Plasma Workspace.

ngraham added a dependency: D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

Restricted Application added a project: Plasma. · View Herald TranscriptOct 8 2018, 4:22 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart added a subscriber: mart.Nov 23 2018, 2:15 PM

mart added inline comments.

lookandfeel/contents/logout/Logout.qml
162	I would have preferred to not have new icons with a translucent circle behind, but rather doing such circle in QML

mart requested changes to this revision.Nov 23 2018, 2:16 PM

This revision now requires changes to proceed.Nov 23 2018, 2:16 PM

ngraham added inline comments.Nov 23 2018, 5:52 PM

lookandfeel/contents/logout/Logout.qml
162	This was discussed endlessly in T9658 and we couldn't find a good way to do it without the result looking really chunky and ugly. I'm open to a batter way to do it if you have some suggestions, though.
162	I mean T9444

We're going in another direction with this.

ngraham mentioned this in D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons.Mar 2 2019, 10:11 PM

Revision Contents
Changeset List

			Path	Packages
M			lookandfeel/contents/logout/Logout.qml (15 lines)

Commit	Tree	Parents	Author	Summary	Date
ad3bf5402969	52117c16f564	3a9dccdc1c64	Nathaniel Graham	Improve logout screen button appearance and contrast (Show More…)	Oct 8 2018, 4:15 AM

Status	Author	Revision
Abandoned	ngraham	D16034 Improve logout screen button appearance and contrast
Abandoned	ngraham	D16031 [SDDM theme] remove blur and increase UI contrast so that it's not required
Needs Revision	pstefan	D15999 Add icons with added background to system.svgz

Diff 43100

View Options

lookandfeel/contents/logout/Logout.qml

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43100	3a9dccd		Oct 8 2018, 4:21 AM	★	★