Add a 'Properties' entry in the places panel context menu
ClosedPublic

Authored by thsurrel on Oct 5 2018, 8:32 PM.

Details

Summary

Twin of D15929 for dolphin

Test Plan

Right-click on a place or on a device in the Places panel now show a Properties entry.
Clicking on it will open its folder property.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Oct 5 2018, 8:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 5 2018, 8:33 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
thsurrel requested review of this revision.Oct 5 2018, 8:33 PM
thsurrel updated this revision to Diff 42984.Oct 6 2018, 7:52 PM

Use isLocalFile

ngraham accepted this revision.Oct 6 2018, 10:44 PM

In your title: Propreties -> Properties

Also, add CCBUG: 181880 to your summary. That will result in the commit details making it into the Bugzilla ticket, but it won't be closed (since D15929 will close it).

Otherwise this looks good and works well! Maybe wait for @elvisangelaccio and/or @anthonyfieroni to give their thumbs-up as well before landing the patch.

This revision is now accepted and ready to land.Oct 6 2018, 10:44 PM
This revision now requires review to proceed.Oct 6 2018, 10:44 PM
elvisangelaccio added inline comments.Oct 7 2018, 9:00 AM
src/filewidgets/kfileplacesmodel.cpp
963 ↗(On Diff #42984)

We usually don't use this->

This revision is now accepted and ready to land.Oct 7 2018, 9:00 AM
thsurrel updated this revision to Diff 43035.Oct 7 2018, 1:27 PM

Don't use this->

thsurrel marked an inline comment as done.Oct 7 2018, 1:28 PM
dfaure requested changes to this revision.Oct 7 2018, 6:24 PM
dfaure added a subscriber: dfaure.
dfaure added inline comments.
src/filewidgets/kfileplacesmodel.cpp
957 ↗(On Diff #43035)

Why is this in the model, rather than being in the view?
It shows a dialog, that sounds more like something for the view.

This revision now requires changes to proceed.Oct 7 2018, 6:24 PM
abetts retitled this revision from Add a 'Propreties' entry in the places panel context menu to Add a 'Properties' entry in the places panel context menu.Oct 7 2018, 6:36 PM
thsurrel updated this revision to Diff 43071.Oct 7 2018, 6:47 PM

Show the KPropertiesDialog from the view instead of the model

dfaure accepted this revision.Oct 7 2018, 8:56 PM
This revision is now accepted and ready to land.Oct 7 2018, 8:56 PM
This revision was automatically updated to reflect the committed changes.