Differential D15867

Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding
ClosedPublic
Actions

Authored by bruns on Oct 1 2018, 12:41 AM.

Details

Reviewers
apol
lbeltrame
Group Reviewers
Frameworks
Commits
R240:c2639d5698dc: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding
Summary

The option is no longer used from any framework, and was always defaulting
to site-packages previously, as INSTALL_DIR_SUFFIX was empty.

Also see D15558, D15845.

Test Plan

build e.g kcoreaddons

Diff Detail

Repository
R240 Extra CMake Modules
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3379
Build 3397: arc lint + arc unit
bruns created this revision.Oct 1 2018, 12:41 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptOct 1 2018, 12:41 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 1 2018, 12:41 AM
bruns added a comment.Oct 15 2018, 2:08 PM

This is a trivial cleanup - can I push it?

lbeltrame accepted this revision.Oct 15 2018, 6:35 PM
lbeltrame added a subscriber: lbeltrame.

Looks OK to me.

This revision is now accepted and ready to land.Oct 15 2018, 6:35 PM
Closed by commit R240:c2639d5698dc: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding (authored by bruns). · Explain WhyOct 16 2018, 1:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42630

View Options

find-modules/FindPythonModuleGeneration.cmake

Loading...