Differential D15558

Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR
ClosedPublic
Actions

Authored by bruns on Sep 16 2018, 7:39 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R244:288d6d3a9d18: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR
Summary

Although KDE_INSTALL_PYTHONBINDINGSDIR follows the the standard pattern
of KDE_INSTALL_<dir> for installation directories, it is not included
in the set of directories set by KDEInstallDirs.cmake.

INSTALL_DIR_SUFFIX does not specify a path but just a suffix and defaults
to "site-packages", i.e. the suffix used by some (but not all) distros.

Removing the (typically empty) optional argument from the function
invocation avoids confusion and allows to remove the parameter.

Test Plan

make

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sep 16 2018, 7:39 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 16 2018, 7:39 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Sep 16 2018, 7:39 PM
apol added a subscriber: apol.Sep 28 2018, 12:38 AM

So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR right?
Makes sense to me to remove this line then, if the default behaviour works for us (it seems so).

bruns added a comment.Sep 28 2018, 12:40 AM
In D15558#333027, @apol wrote:

So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR right?
Makes sense to me to remove this line then, if the default behaviour works for us (it seems so).

Yes, ecm_generate_python_binding checks for None and uses a hardcoded fallback.

apol accepted this revision.Sep 28 2018, 1:18 AM
This revision is now accepted and ready to land.Sep 28 2018, 1:18 AM
Closed by commit R244:288d6d3a9d18: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns). · Explain WhySep 28 2018, 2:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/CMakeLists.txt (1 line)

Diff 42453

View Options

src/lib/CMakeLists.txt

Loading...