Fix window / tab caption in search mode
ClosedPublic

Authored by broulik on Wed, Sep 26, 2:44 PM.

Details

Summary

A search URL is never local, so this part of the code was never reached, resulting in raw baloosearch or filenamesearch URLs showing up as window and tab title

Test Plan

Apparently only in master, I recall there was a bug about this recently?

Ran search for "test", got a window and tab title of "Search for test" instead of "baloosearch:json=blablabla" or "filenamesearch:?search=test"

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Wed, Sep 26, 2:44 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptWed, Sep 26, 2:44 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Wed, Sep 26, 2:44 PM
broulik edited the test plan for this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
broulik added inline comments.Wed, Sep 26, 2:47 PM
src/dolphinviewcontainer.cpp
429

This condition doesn't work for non-active tabs (m_searchBox->isVisible()) but this is a separate bug

ngraham accepted this revision.Wed, Sep 26, 10:06 PM

Thanks, that fixes it!

This revision is now accepted and ready to land.Wed, Sep 26, 10:06 PM
This revision was automatically updated to reflect the committed changes.