Track search mode in variable
ClosedPublic

Authored by broulik on Wed, Sep 26, 2:53 PM.

Details

Summary

Rather than relying on a widget being visible which might not be the case for e.g. non-active tabs

Test Plan

Noticed while testing D15772 that when in a search, pressing Ctrl+T that would open the same search in a new tab would show the url instead because by the time the tab is added and its title evaluated the search box might not have been polished/made visible

  • Ctrl+F → type something → Ctrl+T → now the tab title is correct

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Wed, Sep 26, 2:53 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptWed, Sep 26, 2:53 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Wed, Sep 26, 2:53 PM
ngraham accepted this revision.Wed, Sep 26, 11:11 PM

Requires D15772 to see the fix, but yeah, this fixes it!

This revision is now accepted and ready to land.Wed, Sep 26, 11:11 PM
This revision was automatically updated to reflect the committed changes.