Differential D15423

System settings: make date/time format preview consistent
ClosedPublic
Actions

Authored by McPain on Sep 11 2018, 12:36 PM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
VDG
Commits
R119:d4671edc8198: System settings: make date/time format preview consistent
Summary

BUG: 398493

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
McPain created this revision.Sep 11 2018, 12:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2018, 12:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Sep 11 2018, 12:36 PM
ngraham added a subscriber: ngraham.Sep 11 2018, 12:55 PM

Before-and-after screenshots can make a big difference in the reviewability of a patch like this. :)

McPain added a comment.Sep 11 2018, 1:28 PM

Before:


After:

ngraham added a reviewer: VDG.Sep 11 2018, 2:25 PM

Thanks, that helps!

ngraham accepted this revision as: VDG.Sep 11 2018, 2:44 PM

Looks good to me, and doesn't regress anything in any of the other locales I tried. I'll let @hein do a final review.

davidedmundson added a subscriber: davidedmundson.Sep 28 2018, 11:28 AM
davidedmundson added inline comments.
kcms/formats/kcmformats.cpp
322 ↗(On Diff #41398)

I don't understand, why is this sometimes empty?

McPain added inline comments.Dec 7 2018, 8:47 AM
kcms/formats/kcmformats.cpp
322 ↗(On Diff #41398)

Sorry for delayed reply.

In KCMFormats::initCombo we add locales to combo boxes.
First we add a QString() for "No change" option and then we add all possible locales.

davidedmundson accepted this revision.Apr 15 2019, 10:11 AM
This revision is now accepted and ready to land.Apr 15 2019, 10:11 AM
Closed by commit R119:d4671edc8198: System settings: make date/time format preview consistent (authored by McPain, committed by ngraham). · Explain WhyApr 15 2019, 3:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/formats/kcmformats.cpp (26 lines)

Diff 56302

View Options

kcms/formats/kcmformats.cpp

Loading...