McPain (Oleg Solovyov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 31 2017, 8:11 AM (71 w, 2 d)
Availability
Available

Recent Activity

Yesterday

McPain requested review of D17508: Simplify perStripe definition.
Tue, Dec 11, 3:14 PM · Plasma

Fri, Dec 7

McPain added inline comments to D15423: System settings: make date/time format preview consistent.
Fri, Dec 7, 8:47 AM · Plasma

Wed, Dec 5

McPain updated the summary of D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Wed, Dec 5, 1:05 PM · Plasma
McPain updated the diff for D17217: Implement free memory notifier.

Default limit: 25% -> 10%
Fix typos
Auto detect swap, removed "includeSwap" setting
KSysGuard: show kill button (implemented in D17366)

Wed, Dec 5, 11:11 AM · Plasma
McPain requested review of D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier.
Wed, Dec 5, 11:10 AM · Plasma
McPain added a comment to D17217: Implement free memory notifier.

There's also an alternative that I'd like to suggest:
According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt there's a system called "memory pressure" you can watch for events on a specific FD with various levels of out-of-memory-ness. A lot cheaper than polling, far more reliable, and following the system's OOM configuration. Getting that in at a frameworks level so it can be hooked up to notifications in this case, but also garbage collections in UI code could be pretty cool.

Wed, Dec 5, 10:24 AM · Plasma

Wed, Nov 28

McPain added a comment to D17217: Implement free memory notifier.

Is having this feature an optional feature? Can it be turned off?

Wed, Nov 28, 3:06 PM · Plasma
McPain added a comment to D17217: Implement free memory notifier.

Thanks for all the work!

...But is this actually useful or actionable for the majority of users? Free space is a fairly understandable concept: if you run out, you need to delete things to make more room before you can add more stuff. It won't fix itself unless the user does something. But memory pressure requires a much greater technical understanding and isn't subject to the same conditions. When the system is using up 75% of the available memory, there isn't necessarily a problem at all. Apps will move to swap automatically. Even if there is a problem, it's only temporary, and it may fix itself if the user does nothing as the system shuffles things around.

I worry that this notifier would just be yet another annoying pop-up that people dismiss because they don't understand it.

Wed, Nov 28, 2:58 PM · Plasma
McPain requested review of D17217: Implement free memory notifier.
Wed, Nov 28, 2:04 PM · Plasma
McPain added inline comments to D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Wed, Nov 28, 1:29 PM · Plasma

Oct 15 2018

McPain added a comment to D15247: Show tooltips in krunner.

Any ideas how to fix the bugs I mentioned above, please?

Oct 15 2018, 7:18 AM · Plasma

Oct 12 2018

McPain added a comment to D15247: Show tooltips in krunner.

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

Oct 12 2018, 2:06 PM · Plasma
McPain added a comment to D15247: Show tooltips in krunner.

Found out that sometimes displayed text appears to be elided (not always reproducible)
Resolution: 1920x1080, dpi: 142

Oct 12 2018, 1:58 PM · Plasma

Oct 11 2018

McPain added a comment to D15247: Show tooltips in krunner.

Anybody?

Oct 11 2018, 3:02 PM · Plasma

Oct 8 2018

McPain requested review of D16038: Allow dictionary runner to search multiple times.
Oct 8 2018, 8:37 AM · Plasma

Sep 27 2018

McPain added inline comments to D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Sep 27 2018, 8:20 AM · Plasma
McPain updated the diff for D15333: Group Widget + Color Picker = Widget Out Of Bounds.

(height * 2) + spacer.height -> (height - spacer.height) / 2

Sep 27 2018, 8:19 AM · Plasma
McPain added inline comments to D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Sep 27 2018, 8:17 AM · Plasma

Sep 11 2018

McPain added a comment to D15423: System settings: make date/time format preview consistent.

Before:


After:

Sep 11 2018, 1:28 PM · Plasma
McPain abandoned D11055: Pack python bindings into right dirs.
Sep 11 2018, 12:46 PM · Build System, Frameworks
McPain added a comment to D14064: Dictionary doesn't have enough time to complete query before resetting by milou.

Urgh. Just read the code.

We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back.

That leaves a problem when you search for "firefo" ( with 1 result) to "firefodfhhxtffrdh" with zero results. Which is what this timer "solves"

Clearly its not a good solution to the problem. Changing it to 5 seconds isn't helping.

Sep 11 2018, 12:44 PM · Plasma
McPain added a reviewer for D15333: Group Widget + Color Picker = Widget Out Of Bounds: ngraham.
Sep 11 2018, 12:38 PM · Plasma
McPain requested review of D15423: System settings: make date/time format preview consistent.
Sep 11 2018, 12:36 PM · Plasma

Sep 7 2018

McPain requested review of D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Sep 7 2018, 2:44 PM · Plasma

Sep 6 2018

McPain updated subscribers of D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

+1 for the concept. No opinion about the notification, but I think it's fine. Removing myself as a reviewer since I don't feel qualified to offer a code review. But sounds like you've got a shipit! You need someone to land it for you, right?

Sep 6 2018, 6:26 AM · Plasma

Sep 5 2018

McPain added a comment to D15240: Create a default wallet when user refuses to do so.

I would favor automatically creating a default wallet with the user's current password using a "good enough" cipher that we can hopefully all agree on. This would probably require changes to user-manager, or whatever it is that receives the string used for a new account's password. At the moment when a new user account is created, it would not only create the new user account, but it would also create a wallet using the same password.

Sep 5 2018, 12:51 PM · Frameworks
McPain added a comment to D15240: Create a default wallet when user refuses to do so.

Stuff that doesn't work with KWallet should be fixed. But the point would be moot if we create a default wallet in a more user-friendly manner...

Sep 5 2018, 7:02 AM · Frameworks
McPain added a comment to D15247: Show tooltips in krunner.

Thanks, the patch applies now.

Can you verify that this works for you? When I apply the patch (and reboot for good measure), I still don't see tooltips for items whose names are elided in KRunner.

Sep 5 2018, 6:57 AM · Plasma

Sep 4 2018

McPain added a comment to D15247: Show tooltips in krunner.

The patch does not apply because of an extraneous milou in the path for your diff:

Consider setting up arc; it makes the patch submission process so much simpler and less error-prone. :)

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Sep 4 2018, 1:02 PM · Plasma
McPain added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Just in case, I don't have commit access

Sep 4 2018, 12:57 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Sep 4 2018, 11:41 AM · Plasma
McPain added a comment to D15240: Create a default wallet when user refuses to do so.

This strikes me as likely to cause intense frustration. Consider the following dramatized dialogue between a user and the computer:

User: "Neat, I just set up this KDE plasma thing. Let's start seeing what cool stuff it can do!"
Computer: "Hey hey hey first what kind of KWallet do you want to create? Technical jargon thingy 1, or technical jargon thingy 2? Huh? Huh? What'll it be O noble user!?"
User: "Okay, I have no idea, let me cancel out of this stupid thing..."
Computer: "Don't worry I created a thing anyway and chose technical jargon thingy 1 for you!"

Speaking personally, this sort of experience would make me want to put my fist through the screen.

It might be worth stepping back and asking more higher-level questions like:
"Why are users cancelling the wizard? Is it too technically intimidating?"
"Should we even have a wizard at all? Maybe should we create a wallet automatically by default and let advanced users change its settings or delete it if they don't like it?"

Sep 4 2018, 7:33 AM · Frameworks
McPain updated the diff for D15247: Show tooltips in krunner.
Sep 4 2018, 7:29 AM · Plasma

Sep 3 2018

McPain requested review of D15247: Show tooltips in krunner.
Sep 3 2018, 2:59 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Sep 3 2018, 2:50 PM · Plasma
McPain added a reviewer for D15240: Create a default wallet when user refuses to do so: Frameworks.
Sep 3 2018, 1:10 PM · Frameworks
McPain requested review of D15240: Create a default wallet when user refuses to do so.
Sep 3 2018, 1:09 PM · Frameworks

Aug 27 2018

McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 27 2018, 9:15 AM · Plasma

Aug 24 2018

McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 24 2018, 9:25 AM · Plasma

Aug 20 2018

McPain planned changes to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 20 2018, 9:51 AM · Plasma
McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 20 2018, 6:57 AM · Plasma

Aug 17 2018

McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 3:28 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 3:13 PM · Plasma
McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 3:05 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Used KIO::FileSystemFreeSpaceJob

Aug 17 2018, 2:40 PM · Plasma
McPain added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Might not be an issue as you call setData anyway but just something I want you to keep in mind for testing.

Aug 17 2018, 11:56 AM · Plasma
McPain added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 11:49 AM · Plasma
McPain added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Also beware that bool SolidDeviceEngine::updateSourceEvent is currently supposed to return true

Aug 17 2018, 11:39 AM · Plasma
McPain added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Thanks for looking into this.

Whilst this looks fine, we have a more standard abstraction layer for async IO via KIO.
There's a FileSystemFreeSpaceJob which should work here.

Aug 17 2018, 9:08 AM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 8:56 AM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Removed useless debug string

Aug 17 2018, 7:58 AM · Plasma
McPain requested review of D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 7:49 AM · Plasma

Jul 25 2018

McPain added a comment to D14064: Dictionary doesn't have enough time to complete query before resetting by milou.

ping?

Jul 25 2018, 8:20 AM · Plasma

Jul 19 2018

McPain added a comment to D14208: Duplicated notes in KNotes.

Do you have commit access ?

Jul 19 2018, 6:50 AM · KDE PIM

Jul 18 2018

McPain requested review of D14208: Duplicated notes in KNotes.
Jul 18 2018, 2:43 PM · KDE PIM

Jul 12 2018

McPain added a comment to D14064: Dictionary doesn't have enough time to complete query before resetting by milou.

I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I don't understand why it has this code in the first place.

Jul 12 2018, 2:29 PM · Plasma
McPain updated the summary of D14064: Dictionary doesn't have enough time to complete query before resetting by milou.
Jul 12 2018, 2:25 PM · Plasma
McPain updated the summary of D14063: KRunner Dictionary can't find anything.
Jul 12 2018, 2:24 PM · Plasma
McPain retitled D14064: Dictionary doesn't have enough time to complete query before resetting by milou from Dictionary haven't enough time to complete query before resetting by milou to Dictionary doesn't have enough time to complete query before resetting by milou.
Jul 12 2018, 11:43 AM · Plasma
McPain updated the summary of D14063: KRunner Dictionary can't find anything.
Jul 12 2018, 9:20 AM · Plasma
McPain requested review of D14064: Dictionary doesn't have enough time to complete query before resetting by milou.
Jul 12 2018, 7:22 AM · Plasma
McPain requested review of D14063: KRunner Dictionary can't find anything.
Jul 12 2018, 7:19 AM · Plasma

Mar 5 2018

McPain requested review of D11055: Pack python bindings into right dirs.
Mar 5 2018, 1:11 PM · Build System, Frameworks

Feb 12 2018

McPain accepted D10338: Don't show tooltips for inactive windows.

This commit looks good and it works just as planned

Feb 12 2018, 2:01 PM · Plasma

Jan 23 2018

McPain abandoned D9506: milti-screen sleep fix.
Jan 23 2018, 9:43 AM · Plasma

Jan 22 2018

McPain added a reviewer for D9791: Wrong progress in tray: sandsmark.
Jan 22 2018, 12:12 PM
McPain added a comment to D9506: milti-screen sleep fix.

UPD:
I found monitor combination that makes KScreen works: AOC(hdmi)-iiyama(D-SUB)
If I swap monitors, KSCeen doesn't work (noticed it past friday evening)

Jan 22 2018, 9:24 AM · Plasma

Jan 19 2018

McPain added a comment to D9506: milti-screen sleep fix.
In D9506#193271, @sebas wrote:

Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review.

Jan 19 2018, 10:44 AM · Plasma

Jan 17 2018

McPain updated the diff for D7246: Tooltips.

Fix autotests build

Jan 17 2018, 1:40 PM · Breeze, Plasma

Jan 16 2018

McPain added a comment to D9506: milti-screen sleep fix.

I noticed that "shutdown" sequence is not the same as "standby" one.
Shutdown for secondary:
disconnect -> remove crtc -> connect -> assign crtc

Jan 16 2018, 9:37 AM · Plasma

Jan 15 2018

McPain added a comment to D9294: KWin: tooltips.

I already did and my accepted still holds

Jan 15 2018, 3:35 PM · KWin

Jan 12 2018

McPain updated subscribers of D9294: KWin: tooltips.

@graesslin thanks for review.
Can you look at new version of KDecoration part requested by @cfeck ?

Jan 12 2018, 9:29 AM · KWin

Jan 11 2018

McPain updated the diff for D9294: KWin: tooltips.

const QString &

Jan 11 2018, 10:15 AM · KWin
McPain updated the diff for D7246: Tooltips.

const QString &
cleanup

Jan 11 2018, 10:15 AM · Breeze, Plasma

Jan 10 2018

McPain added a comment to D9506: milti-screen sleep fix.

@McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix.

Jan 10 2018, 12:49 PM · Plasma
McPain updated the diff for D7246: Tooltips.

fix build

Jan 10 2018, 12:32 PM · Breeze, Plasma
McPain updated the diff for D7246: Tooltips.
Jan 10 2018, 12:23 PM · Breeze, Plasma
McPain updated the diff for D9294: KWin: tooltips.
Jan 10 2018, 12:12 PM · KWin

Jan 9 2018

McPain added a comment to D9506: milti-screen sleep fix.
In D9506#188118, @sebas wrote:

And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup.

Can you please merge this quickly? I'd like to give it some real-world exposure, we can always revisit this patch if it turns out to cause more problems than it solves.

Jan 9 2018, 1:33 PM · Plasma

Dec 29 2017

McPain planned changes to D9506: milti-screen sleep fix.

UPD:
As the secondary monitor switches off, windows on it doesn't move to the primary

Dec 29 2017, 12:16 PM · Plasma

Dec 28 2017

McPain added inline comments to D7246: Tooltips.
Dec 28 2017, 11:53 AM · Breeze, Plasma
McPain added inline comments to D9294: KWin: tooltips.
Dec 28 2017, 11:53 AM · KWin

Dec 27 2017

McPain updated the summary of D9294: KWin: tooltips.
Dec 27 2017, 7:27 AM · KWin

Dec 26 2017

McPain created D9506: milti-screen sleep fix.
Dec 26 2017, 1:40 PM · Plasma

Dec 13 2017

McPain updated the diff for D9294: KWin: tooltips.
Dec 13 2017, 1:32 PM · KWin
McPain updated the diff for D7246: Tooltips.
Dec 13 2017, 1:32 PM · Breeze, Plasma
McPain updated the diff for D9294: KWin: tooltips.
Dec 13 2017, 1:07 PM · KWin
McPain updated the diff for D7246: Tooltips.
Dec 13 2017, 1:06 PM · Breeze, Plasma
McPain updated the diff for D9294: KWin: tooltips.

Pass QString as "const QString &"
(noticed that after sending previous patch)

Dec 13 2017, 12:48 PM · KWin
McPain updated the diff for D7246: Tooltips.
Dec 13 2017, 12:46 PM · Breeze, Plasma
McPain updated the diff for D9294: KWin: tooltips.

Removed "bool trap"

Dec 13 2017, 12:22 PM · KWin
McPain updated the diff for D7246: Tooltips.

Removed "bool trap"

Dec 13 2017, 12:22 PM · Breeze, Plasma

Dec 12 2017

McPain updated the diff for D9294: KWin: tooltips.

Remove accidently attached russian translation patch

Dec 12 2017, 9:41 AM · KWin
McPain updated the summary of D7246: Tooltips.
Dec 12 2017, 9:39 AM · Breeze, Plasma
McPain created D9294: KWin: tooltips.
Dec 12 2017, 9:39 AM · KWin
McPain updated the diff for D7246: Tooltips.

Moved QToolTip::showText to KWin

Dec 12 2017, 9:38 AM · Breeze, Plasma

Dec 11 2017

McPain added a comment to D7246: Tooltips.

One more question:

Dec 11 2017, 1:09 PM · Breeze, Plasma

Dec 8 2017

McPain added a comment to D7246: Tooltips.

But long story short: for KWin the best is a request from KDecoration "showTooltip(const QString &)" and KWin creates the tooltip window, positions it and ensures it works correctly.

Dec 8 2017, 8:52 AM · Breeze, Plasma

Nov 24 2017

McPain updated the diff for D7246: Tooltips.
Nov 24 2017, 11:10 AM · Breeze, Plasma
McPain updated the diff for D7246: Tooltips.
Nov 24 2017, 9:10 AM · Breeze, Plasma