McPain (Oleg Solovyov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 31 2017, 8:11 AM (107 w, 3 d)
Availability
Available

Recent Activity

Jun 18 2019

McPain added a comment to D21872: Translate keyboard layouts in sddm.

It might be better to do it in

XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.

I don't see any matching files in sddm

https://github.com/sddm/sddm/blob/develop/src/greeter/XcbKeyboardBackend.cpp

Jun 18 2019, 8:38 AM · Plasma

Jun 17 2019

McPain added a comment to D21872: Translate keyboard layouts in sddm.

It might be better to do it in

XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.

Jun 17 2019, 11:16 AM · Plasma
McPain added a comment to D21872: Translate keyboard layouts in sddm.

Jun 17 2019, 9:58 AM · Plasma
McPain added a reviewer for D21872: Translate keyboard layouts in sddm: ngraham.
Jun 17 2019, 9:56 AM · Plasma
McPain requested review of D21872: Translate keyboard layouts in sddm.
Jun 17 2019, 9:56 AM · Plasma

Jun 4 2019

McPain committed R119:a14258a0cd60: fill layouts from X server when there are no layouts in config (authored by McPain).
fill layouts from X server when there are no layouts in config
Jun 4 2019, 2:22 PM
McPain closed D21497: fill layouts from X server when there are no layouts in config.
Jun 4 2019, 2:22 PM · Plasma

Jun 3 2019

McPain added a comment to D15247: Show tooltips in krunner.

IMO what's seen in your screenshot is not useful behavior. If the full text fits in the regular UI, there's no need to show a tooltip; it's just redundant.

Jun 3 2019, 9:31 AM · Plasma
McPain added a comment to D21497: fill layouts from X server when there are no layouts in config.

Looks good and works for me, though I'm not super familiar with this code so I'd appreciate a review from @hein or @broulik.

Jun 3 2019, 9:31 AM · Plasma

May 31 2019

McPain updated the diff for D21497: fill layouts from X server when there are no layouts in config.

style: for

May 31 2019, 2:51 PM · Plasma
McPain updated the diff for D21497: fill layouts from X server when there are no layouts in config.

foreach -> for
use const

May 31 2019, 2:13 PM · Plasma
McPain added a comment to D15247: Show tooltips in krunner.

I am still not actually getting any tooltips when I hover over an elided entry.

May 31 2019, 11:05 AM · Plasma
McPain updated the diff for D21497: fill layouts from X server when there are no layouts in config.

updated paths

May 31 2019, 7:15 AM · Plasma

May 30 2019

McPain updated the diff for D21497: fill layouts from X server when there are no layouts in config.
  1. Overwrite configureLayouts based on whether layouts is empty or not
  2. Make sure fetched layouts were saved to config
May 30 2019, 1:43 PM · Plasma
McPain added reviewers for D21497: fill layouts from X server when there are no layouts in config: ngraham, broulik.
May 30 2019, 9:56 AM · Plasma
McPain requested review of D21497: fill layouts from X server when there are no layouts in config.
May 30 2019, 9:56 AM · Plasma
McPain added a comment to D15247: Show tooltips in krunner.
In D15247#364814, @mart wrote:

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

there was a recent fix in the kwin morphingpopup effect that should have fixed it, i would say go for it

May 30 2019, 9:32 AM · Plasma

May 22 2019

McPain added a comment to D15247: Show tooltips in krunner.
In D15247#364814, @mart wrote:

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

there was a recent fix in the kwin morphingpopup effect that should have fixed it, i would say go for it

May 22 2019, 7:46 AM · Plasma

Apr 30 2019

McPain committed R116:257b03b185d3: Reject invalid keys (authored by McPain).
Reject invalid keys
Apr 30 2019, 1:21 PM
McPain closed D20900: Reject invalid keys.
Apr 30 2019, 1:21 PM · Plasma
McPain committed R116:4cb1e69c1a61: Reset model when there are new available connections (authored by McPain).
Reset model when there are new available connections
Apr 30 2019, 1:21 PM
McPain closed D20788: Reset model when there are new available connections.
Apr 30 2019, 1:21 PM · Plasma
McPain updated the diff for D20900: Reject invalid keys.
Apr 30 2019, 11:42 AM · Plasma
McPain updated the diff for D20900: Reject invalid keys.
Apr 30 2019, 10:19 AM · Plasma
McPain updated the diff for D20900: Reject invalid keys.

validate WPA-PSK and WEP keys

Apr 30 2019, 9:02 AM · Plasma
McPain updated the diff for D20900: Reject invalid keys.

Use validation

Apr 30 2019, 8:27 AM · Plasma

Apr 29 2019

McPain added a comment to D20788: Reset model when there are new available connections.

You said it's broken so I would preffer not landing a broken patch.

Apr 29 2019, 3:04 PM · Plasma
McPain requested review of D20788: Reset model when there are new available connections.

Tomorrow I'll land this patch, but I submitted another one

Apr 29 2019, 2:51 PM · Plasma
McPain requested review of D20900: Reject invalid keys.
Apr 29 2019, 2:50 PM · Plasma
McPain added a comment to D20788: Reset model when there are new available connections.

I think resetting the model might not be necessary, when addAvailableConnection() is called, it then updates item with a new available connection, which invalidates the filter anyway or at least it should.

Apr 29 2019, 12:39 PM · Plasma
McPain planned changes to D20788: Reset model when there are new available connections.

The patch "as-is" is broken.
I had reports about resetting model right after clicking "Connect" button - model resets and there are no connection attempts.

Apr 29 2019, 6:04 AM · Plasma

Apr 24 2019

McPain requested review of D20788: Reset model when there are new available connections.
Apr 24 2019, 1:49 PM · Plasma

Apr 2 2019

McPain added a comment to D18979: foldermodel: store information about screen used.
In D18979#441799, @hein wrote:

Thanks! Do you need help landing this?

Apr 2 2019, 7:49 AM · Plasma

Apr 1 2019

McPain added a comment to D18979: foldermodel: store information about screen used.
In D18979#428230, @hein wrote:

Can you explain more what this is trying to achieve / what it solves with an example?

Apr 1 2019, 2:28 PM · Plasma

Feb 13 2019

McPain requested review of D18979: foldermodel: store information about screen used.

Seems like I can't use distinct screen mapping for each activity yet

Feb 13 2019, 12:52 PM · Plasma
McPain planned changes to D18979: foldermodel: store information about screen used.
Feb 13 2019, 12:20 PM · Plasma
McPain added reviewers for D18979: foldermodel: store information about screen used: broulik, sebas.
Feb 13 2019, 12:16 PM · Plasma
McPain requested review of D18979: foldermodel: store information about screen used.
Feb 13 2019, 12:12 PM · Plasma

Feb 1 2019

McPain added inline comments to D18182: Fix new file creation leading to dupe items on a fresh view.
Feb 1 2019, 11:17 AM · Plasma

Jan 31 2019

McPain added a comment to D18182: Fix new file creation leading to dupe items on a fresh view.

Somebody review this for me, please, I'm too far away from actually testing it

Jan 31 2019, 8:11 AM · Plasma

Jan 23 2019

McPain requested changes to D18182: Fix new file creation leading to dupe items on a fresh view.

That's what I got with this patch.

Jan 23 2019, 2:38 PM · Plasma

Jan 21 2019

McPain added a comment to D17217: Implement free memory notifier.

Thanks. Any examples in KDE? I can't implement this from scratch right now.

There is not, it would requires writing new C code.
It's something I can help with.

Jan 21 2019, 2:49 PM · Plasma

Jan 15 2019

McPain added inline comments to D18182: Fix new file creation leading to dupe items on a fresh view.
Jan 15 2019, 1:37 PM · Plasma

Jan 14 2019

McPain abandoned D17707: FolderView: set sort mode to unserted after catching insert signal.
Jan 14 2019, 9:10 AM · Plasma
McPain abandoned D17689: [RFC] Positioner: call initMaps even if m_enabled == false.
Jan 14 2019, 9:09 AM · Plasma
McPain accepted D18182: Fix new file creation leading to dupe items on a fresh view.

It works, thanks.
Removed D17689 and D17707 patches so I close then

Jan 14 2019, 9:09 AM · Plasma
McPain added a comment to D17689: [RFC] Positioner: call initMaps even if m_enabled == false.
In D17689#391265, @hein wrote:
Jan 14 2019, 8:32 AM · Plasma

Jan 10 2019

McPain added a comment to D17689: [RFC] Positioner: call initMaps even if m_enabled == false.
In D17689#379900, @hein wrote:

Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019.

Jan 10 2019, 8:30 AM · Plasma

Dec 27 2018

McPain added inline comments to D17809: Check icon positions after move.
Dec 27 2018, 8:11 AM · Plasma
McPain updated the diff for D17809: Check icon positions after move.

Fixed condition mistake

Dec 27 2018, 8:07 AM · Plasma

Dec 26 2018

McPain requested review of D17809: Check icon positions after move.
Dec 26 2018, 2:54 PM · Plasma

Dec 20 2018

McPain requested review of D17707: FolderView: set sort mode to unserted after catching insert signal.
Dec 20 2018, 11:16 AM · Plasma
McPain updated the summary of D17689: [RFC] Positioner: call initMaps even if m_enabled == false.
Dec 20 2018, 10:51 AM · Plasma

Dec 19 2018

McPain requested review of D17689: [RFC] Positioner: call initMaps even if m_enabled == false.
Dec 19 2018, 2:36 PM · Plasma

Dec 18 2018

McPain added a comment to D17217: Implement free memory notifier.

Anybody?

Dec 18 2018, 10:37 AM · Plasma

Dec 11 2018

McPain requested review of D17508: Simplify perStripe definition.
Dec 11 2018, 3:14 PM · Plasma

Dec 7 2018

McPain added inline comments to D15423: System settings: make date/time format preview consistent.
Dec 7 2018, 8:47 AM · Plasma

Dec 5 2018

McPain updated the summary of D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Dec 5 2018, 1:05 PM · Plasma
McPain updated the diff for D17217: Implement free memory notifier.

Default limit: 25% -> 10%
Fix typos
Auto detect swap, removed "includeSwap" setting
KSysGuard: show kill button (implemented in D17366)

Dec 5 2018, 11:11 AM · Plasma
McPain requested review of D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier.
Dec 5 2018, 11:10 AM · Plasma
McPain added a comment to D17217: Implement free memory notifier.

There's also an alternative that I'd like to suggest:
According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt there's a system called "memory pressure" you can watch for events on a specific FD with various levels of out-of-memory-ness. A lot cheaper than polling, far more reliable, and following the system's OOM configuration. Getting that in at a frameworks level so it can be hooked up to notifications in this case, but also garbage collections in UI code could be pretty cool.

Dec 5 2018, 10:24 AM · Plasma

Nov 28 2018

McPain added a comment to D17217: Implement free memory notifier.

Is having this feature an optional feature? Can it be turned off?

Nov 28 2018, 3:06 PM · Plasma
McPain added a comment to D17217: Implement free memory notifier.

Thanks for all the work!

...But is this actually useful or actionable for the majority of users? Free space is a fairly understandable concept: if you run out, you need to delete things to make more room before you can add more stuff. It won't fix itself unless the user does something. But memory pressure requires a much greater technical understanding and isn't subject to the same conditions. When the system is using up 75% of the available memory, there isn't necessarily a problem at all. Apps will move to swap automatically. Even if there is a problem, it's only temporary, and it may fix itself if the user does nothing as the system shuffles things around.

I worry that this notifier would just be yet another annoying pop-up that people dismiss because they don't understand it.

Nov 28 2018, 2:58 PM · Plasma
McPain requested review of D17217: Implement free memory notifier.
Nov 28 2018, 2:04 PM · Plasma
McPain added inline comments to D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Nov 28 2018, 1:29 PM · Plasma

Oct 15 2018

McPain added a comment to D15247: Show tooltips in krunner.

Any ideas how to fix the bugs I mentioned above, please?

Oct 15 2018, 7:18 AM · Plasma

Oct 12 2018

McPain added a comment to D15247: Show tooltips in krunner.

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

Oct 12 2018, 2:06 PM · Plasma
McPain added a comment to D15247: Show tooltips in krunner.

Found out that sometimes displayed text appears to be elided (not always reproducible)
Resolution: 1920x1080, dpi: 142

Oct 12 2018, 1:58 PM · Plasma

Oct 11 2018

McPain added a comment to D15247: Show tooltips in krunner.

Anybody?

Oct 11 2018, 3:02 PM · Plasma

Oct 8 2018

McPain requested review of D16038: Allow dictionary runner to search multiple times.
Oct 8 2018, 8:37 AM · Plasma

Sep 27 2018

McPain added inline comments to D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Sep 27 2018, 8:20 AM · Plasma
McPain updated the diff for D15333: Group Widget + Color Picker = Widget Out Of Bounds.

(height * 2) + spacer.height -> (height - spacer.height) / 2

Sep 27 2018, 8:19 AM · Plasma
McPain added inline comments to D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Sep 27 2018, 8:17 AM · Plasma

Sep 11 2018

McPain added a comment to D15423: System settings: make date/time format preview consistent.

Before:


After:

Sep 11 2018, 1:28 PM · Plasma
McPain abandoned D11055: Pack python bindings into right dirs.
Sep 11 2018, 12:46 PM · Build System, Frameworks
McPain added a comment to D14064: Dictionary doesn't have enough time to complete query before resetting by milou.

Urgh. Just read the code.

We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back.

That leaves a problem when you search for "firefo" ( with 1 result) to "firefodfhhxtffrdh" with zero results. Which is what this timer "solves"

Clearly its not a good solution to the problem. Changing it to 5 seconds isn't helping.

Sep 11 2018, 12:44 PM · Plasma
McPain added a reviewer for D15333: Group Widget + Color Picker = Widget Out Of Bounds: ngraham.
Sep 11 2018, 12:38 PM · Plasma
McPain requested review of D15423: System settings: make date/time format preview consistent.
Sep 11 2018, 12:36 PM · Plasma

Sep 7 2018

McPain requested review of D15333: Group Widget + Color Picker = Widget Out Of Bounds.
Sep 7 2018, 2:44 PM · Plasma

Sep 6 2018

McPain updated subscribers of D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

+1 for the concept. No opinion about the notification, but I think it's fine. Removing myself as a reviewer since I don't feel qualified to offer a code review. But sounds like you've got a shipit! You need someone to land it for you, right?

Sep 6 2018, 6:26 AM · Plasma

Sep 5 2018

McPain added a comment to D15240: Create a default wallet when user refuses to do so.

I would favor automatically creating a default wallet with the user's current password using a "good enough" cipher that we can hopefully all agree on. This would probably require changes to user-manager, or whatever it is that receives the string used for a new account's password. At the moment when a new user account is created, it would not only create the new user account, but it would also create a wallet using the same password.

Sep 5 2018, 12:51 PM · Frameworks
McPain added a comment to D15240: Create a default wallet when user refuses to do so.

Stuff that doesn't work with KWallet should be fixed. But the point would be moot if we create a default wallet in a more user-friendly manner...

Sep 5 2018, 7:02 AM · Frameworks
McPain added a comment to D15247: Show tooltips in krunner.

Thanks, the patch applies now.

Can you verify that this works for you? When I apply the patch (and reboot for good measure), I still don't see tooltips for items whose names are elided in KRunner.

Sep 5 2018, 6:57 AM · Plasma

Sep 4 2018

McPain added a comment to D15247: Show tooltips in krunner.

The patch does not apply because of an extraneous milou in the path for your diff:

Consider setting up arc; it makes the patch submission process so much simpler and less error-prone. :)

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Sep 4 2018, 1:02 PM · Plasma
McPain added a comment to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Just in case, I don't have commit access

Sep 4 2018, 12:57 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Sep 4 2018, 11:41 AM · Plasma
McPain added a comment to D15240: Create a default wallet when user refuses to do so.

This strikes me as likely to cause intense frustration. Consider the following dramatized dialogue between a user and the computer:

User: "Neat, I just set up this KDE plasma thing. Let's start seeing what cool stuff it can do!"
Computer: "Hey hey hey first what kind of KWallet do you want to create? Technical jargon thingy 1, or technical jargon thingy 2? Huh? Huh? What'll it be O noble user!?"
User: "Okay, I have no idea, let me cancel out of this stupid thing..."
Computer: "Don't worry I created a thing anyway and chose technical jargon thingy 1 for you!"

Speaking personally, this sort of experience would make me want to put my fist through the screen.

It might be worth stepping back and asking more higher-level questions like:
"Why are users cancelling the wizard? Is it too technically intimidating?"
"Should we even have a wizard at all? Maybe should we create a wallet automatically by default and let advanced users change its settings or delete it if they don't like it?"

Sep 4 2018, 7:33 AM · Frameworks
McPain updated the diff for D15247: Show tooltips in krunner.
Sep 4 2018, 7:29 AM · Plasma

Sep 3 2018

McPain requested review of D15247: Show tooltips in krunner.
Sep 3 2018, 2:59 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Sep 3 2018, 2:50 PM · Plasma
McPain added a reviewer for D15240: Create a default wallet when user refuses to do so: Frameworks.
Sep 3 2018, 1:10 PM · Frameworks
McPain requested review of D15240: Create a default wallet when user refuses to do so.
Sep 3 2018, 1:09 PM · Frameworks

Aug 27 2018

McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 27 2018, 9:15 AM · Plasma

Aug 24 2018

McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 24 2018, 9:25 AM · Plasma

Aug 20 2018

McPain planned changes to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 20 2018, 9:51 AM · Plasma
McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 20 2018, 6:57 AM · Plasma

Aug 17 2018

McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 3:28 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 3:13 PM · Plasma
McPain added inline comments to D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.
Aug 17 2018, 3:05 PM · Plasma
McPain updated the diff for D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it.

Used KIO::FileSystemFreeSpaceJob

Aug 17 2018, 2:40 PM · Plasma