System settings: make date/time format preview consistent
ClosedPublic

Authored by McPain on Sep 11 2018, 12:36 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Sep 11 2018, 12:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2018, 12:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Sep 11 2018, 12:36 PM

Before-and-after screenshots can make a big difference in the reviewability of a patch like this. :)

Before:


After:

ngraham added a reviewer: VDG.Sep 11 2018, 2:25 PM

Thanks, that helps!

ngraham accepted this revision as: VDG.Sep 11 2018, 2:44 PM

Looks good to me, and doesn't regress anything in any of the other locales I tried. I'll let @hein do a final review.

davidedmundson added inline comments.
kcms/formats/kcmformats.cpp
322

I don't understand, why is this sometimes empty?

McPain added inline comments.Dec 7 2018, 8:47 AM
kcms/formats/kcmformats.cpp
322

Sorry for delayed reply.

In KCMFormats::initCombo we add locales to combo boxes.
First we add a QString() for "No change" option and then we add all possible locales.

davidedmundson accepted this revision.Apr 15 2019, 10:11 AM
This revision is now accepted and ready to land.Apr 15 2019, 10:11 AM
This revision was automatically updated to reflect the committed changes.