[xwl] Add Xwayland interface class
ClosedPublic
Actions

Authored by romangg on Sep 11 2018, 11:20 AM.

Details

Reviewers

davidedmundson
zzag

Group Reviewers

KWin

Commits

R108:ad1bcbecc789: [xwl] Add Xwayland interface class

Summary

Adds an interface class to access Xwayland members from within KWin core.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg requested review of this revision.Sep 11 2018, 11:20 AM

romangg created this revision.

Harbormaster completed remote builds in B2713: Diff 41394.Sep 11 2018, 11:20 AM

romangg added a dependency: D15063: Remove X clipboard sync helper and rename its autotest.Sep 11 2018, 11:21 AM

Rebase on master.

Restricted Application added a project: KWin. · View Herald TranscriptSep 20 2018, 9:17 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

Harbormaster completed remote builds in B3044: Diff 42012.Sep 20 2018, 9:17 PM

romangg added a dependent revision: D15627: [xwl] Drag and drop between Xwayland and Wayland native clients.Sep 20 2018, 9:32 PM

It seems like you're just recreating KWIN_SINGLETON

xwl/xwayland.h
43	I don't understand. What does this inheritance do that this existing method doesn't do

davidedmundson requested changes to this revision.Oct 5 2018, 12:20 AM

This revision now requires changes to proceed.Oct 5 2018, 12:20 AM

In D15419#336932, @davidedmundson wrote:

It seems like you're just recreating KWIN_SINGLETON

I tried to use KWIN_SINGLETON but its macros do not work with inheritance.

xwl/xwayland.h
43	XwaylandIface is compiled into KWin core while class Xwayland is only compiled into the kwin_wayland binary.

Rebase on master/changes.

Harbormaster completed remote builds in B6555: Diff 48527.Jan 2 2019, 12:18 PM

Stupid question: why do we need XwaylandIface?

In D15419#385156, @zzag wrote:

Stupid question: why do we need XwaylandIface?

Such that we can compile Xwayland class only into the Wayland binary, not into KWin core.

Oh, I didn't notice an inline comment that explains why.

xwl/xwayland_iface.h
30 ↗	(On Diff #48527)	Please follow coding style, no short names.

zzag requested changes to this revision.Feb 6 2019, 11:41 AM

zzag added inline comments.

xwl/xwayland_iface.cpp
22 ↗	(On Diff #48527)	namespace KWin {
26 ↗	(On Diff #48527)	XwaylandInterface *XwaylandInterface::self() { }
xwl/xwayland_iface.h
30 ↗	(On Diff #48527)	XwaylandInterface
42 ↗	(On Diff #48527)	inline XwaylandInterface *xwayland() { }

This revision now requires changes to proceed.Feb 6 2019, 11:41 AM

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 19 2019, 11:59 AM

Closed by commit R108:ad1bcbecc789: [xwl] Add Xwayland interface class (authored by romangg). · Explain Why

This revision was automatically updated to reflect the committed changes.

romangg marked 5 inline comments as done.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
M		xwl/xwayland.h (4 lines)
M		xwl/xwayland.cpp (2 lines)
A	M	xwl/xwayland_interface.h (47 lines)
A	M	xwl/xwayland_interface.cpp (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41394	9305f71		Sep 11 2018, 11:20 AM	★	★
Diff 2	42012	7037816	Rebase on master.	Sep 20 2018, 9:17 PM	★	★
Diff 3	48527	622ece8	Rebase on master/changes.	Jan 2 2019, 12:18 PM	★	★
Diff 4	52055	2776f82	R108:ad1bcbecc78981d9d55411b774e09fbeab414d42	Feb 19 2019, 11:59 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
00adbc71ada7	5d2b097acad7	622ece8a9c35	Roman Gilg	[xwl] Add Xwayland interface class (Show More…)	Aug 22 2018, 12:36 PM

Status	Author	Revision
Closed	romangg	D15628 [xwl] Support stack optimizing X drag source clients
Closed	romangg	D15629 [xwl] text/x-uri converter for selected X url list format targets
Closed	romangg	D15627 [xwl] Drag and drop between Xwayland and Wayland native clients
Closed	romangg	D15419 [xwl] Add Xwayland interface class
Closed	romangg	D15063 Remove X clipboard sync helper and rename its autotest
Closed	romangg	D15061 [xwl] Generic X selections translation mechanism with Clipboard support
Closed	romangg	D15022 [autotests] Use Xwayland class in WaylandTestApplication
Closed	romangg	D15020 [xwl] Move Xwayland parts into separate class
Closed	romangg	D15421 [server] Add surface data proxy mechanism
Closed	romangg	D15023 [server] Add selectionChanged signal