Adds an interface class to access Xwayland members from within KWin core.
Details
Details
- Reviewers
davidedmundson zzag - Group Reviewers
KWin - Commits
- R108:ad1bcbecc789: [xwl] Add Xwayland interface class
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- 0ifaceXwl
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6555 Build 6573: arc lint + arc unit
Comment Actions
It seems like you're just recreating KWIN_SINGLETON
xwl/xwayland.h | ||
---|---|---|
43 | I don't understand. What does this inheritance do that this existing method doesn't do |
Comment Actions
I tried to use KWIN_SINGLETON but its macros do not work with inheritance.
xwl/xwayland.h | ||
---|---|---|
43 | XwaylandIface is compiled into KWin core while class Xwayland is only compiled into the kwin_wayland binary. |
Comment Actions
Such that we can compile Xwayland class only into the Wayland binary, not into KWin core.
Comment Actions
Oh, I didn't notice an inline comment that explains why.
xwl/xwayland_iface.h | ||
---|---|---|
30 | Please follow coding style, no short names. |