Remove X clipboard sync helper and rename its autotest

Authored by romangg on Aug 24 2018, 8:37 PM.



With the gneric X selections infrastructure and clipboard support the X
clipboard sync helper utility can be removed. Also rename its autotest as it
tests the inner workings of the new mechanism since this mechanism was

Test Plan

Autotest still passes under new name.

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
romangg requested review of this revision.Aug 24 2018, 8:37 PM
romangg created this revision.
romangg updated this revision to Diff 41389.Sep 11 2018, 10:49 AM

Rebase on master.

romangg updated this revision to Diff 42011.Sep 20 2018, 9:14 PM

Rebase on master.

Restricted Application added a project: KWin. · View Herald TranscriptSep 20 2018, 9:14 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson accepted this revision.Oct 5 2018, 12:27 AM
This revision is now accepted and ready to land.Oct 5 2018, 12:27 AM

I want to point out that the main motivation for the dedicated process is to make KWin not an attack target by clients. The danger I see is that a malicious client sets a large clipboard data causing KWin to go out of memory. As the data source process passes a pipe which we have to read in order to sync to X11 we have to get all the data and allocate memory for it. The dedicated process was my solution to protect against this possible attack (which btw. also works for containerized applications such as flatpack). It would be the clipboard sync process which goes oom and killed, but not the complete session.

I don't mind that it gets moved into KWin, but we should add a memory restriction to ensure we cannot be attacked from clients through the clipboard.

romangg updated this revision to Diff 48523.Jan 2 2019, 12:06 PM

Rebase on master/changes.

romangg updated this revision to Diff 48524.Jan 2 2019, 12:13 PM
  • Deleate files again
This revision was automatically updated to reflect the committed changes.