Also check smb-share for whether it's an SMB mount
ClosedPublic
Actions

Authored by broulik on Aug 29 2018, 10:35 PM.

Details

Reviewers

dfaure
ngraham

Commits

Summary

This is the "type" exposed by gvfsd

CCBUG: 344146

Test Plan

Depends on D15153

I no longer get a "failed to change permission error" when copying a file onto a SMB share mounted by gvfs

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Aug 29 2018, 10:35 PM

Yup, this fixes that issue for me.

This revision is now accepted and ready to land.Aug 30 2018, 1:17 PM

Can you add a comment mentioning where "smb-share" is comming from? Otherwise, +1

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/kmountpoint.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40671			Aug 29 2018, 10:33 PM	★	★
Diff 2	40733	5fb35a3	R241:97b8d5f1ec476b9d2f664ac6b774d3a32cf58f16	Aug 31 2018, 7:21 AM	★	★

	Status	Author	Revision
	Closed	broulik	D15154 Also check smb-share for whether it's an SMB mount
	Closed	broulik	D15153 RFC: Resolve gvfsd mounts