With the gneric X selections infrastructure and clipboard support the X
clipboard sync helper utility can be removed. Also rename its autotest as it
tests the inner workings of the new mechanism since this mechanism was
introduced.
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:2776f829efbd: Remove X clipboard sync helper and rename its autotest
Autotest still passes under new name.
Diff Detail
- Branch
- 0rmHelper
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2711 Build 2729: arc lint + arc unit
I want to point out that the main motivation for the dedicated process is to make KWin not an attack target by clients. The danger I see is that a malicious client sets a large clipboard data causing KWin to go out of memory. As the data source process passes a pipe which we have to read in order to sync to X11 we have to get all the data and allocate memory for it. The dedicated process was my solution to protect against this possible attack (which btw. also works for containerized applications such as flatpack). It would be the clipboard sync process which goes oom and killed, but not the complete session.
I don't mind that it gets moved into KWin, but we should add a memory restriction to ensure we cannot be attacked from clients through the clipboard.