Details
Details
- Reviewers
jausmus
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Do not use QDir::separator
if (!folder.endsWith(QLatin1Char('/')) { folder += QLatin1Char('/'); }
Comment Actions
I believe this explains why QDirSeparator should not be used here: http://agateau.com/2015/qdir-separator-considered-harmful/
Comment Actions
- Use a proper commit message, with subject and body
- Please use "arc diff ..." to upload the diff, revisions without context are hard to review.
Comment Actions
Will do, my apologies. Hadn't realized the git commit message wouldn't be pulled in via the web interface upload. :)