Do not use QDir::separator

if (!folder.endsWith(QLatin1Char('/')) {
    folder += QLatin1Char('/');
}

In D15013#313867, @anthonyfieroni wrote:

Do not use QDir::separator

if (!folder.endsWith(QLatin1Char('/')) {
    folder += QLatin1Char('/');
}

Does balooctl not need cross platform support?

In D15013#313880, @jausmus wrote:

In D15013#313867, @anthonyfieroni wrote:

Do not use QDir::separator

if (!folder.endsWith(QLatin1Char('/')) {
    folder += QLatin1Char('/');
}

Does balooctl not need cross platform support?

I believe this explains why QDirSeparator should not be used here: http://agateau.com/2015/qdir-separator-considered-harmful/

In D15013#313885, @mgallien wrote:

In D15013#313880, @jausmus wrote:

In D15013#313867, @anthonyfieroni wrote:

Do not use QDir::separator

if (!folder.endsWith(QLatin1Char('/')) {
    folder += QLatin1Char('/');
}

Does balooctl not need cross platform support?

I believe this explains why QDirSeparator should not be used here: http://agateau.com/2015/qdir-separator-considered-harmful/

Got it - will update and resubmit. Thanks!

In D15013#314082, @bruns wrote:

1. Use a proper commit message, with subject and body
2. Please use "arc diff ..." to upload the diff, revisions without context are hard to review.

Will do, my apologies. Hadn't realized the git commit message wouldn't be pulled in via the web interface upload. :)