jausmus (James Ausmus)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2018, 4:35 AM (297 w, 2 d)
Availability
Available

Recent Activity

Aug 23 2018

jausmus added a comment to D15013: balootctl: fix 396535.
  1. Use a proper commit message, with subject and body
  2. Please use "arc diff ..." to upload the diff, revisions without context are hard to review.
Aug 23 2018, 2:58 PM · Baloo, Frameworks
jausmus added a comment to D15013: balootctl: fix 396535.

Do not use QDir::separator

if (!folder.endsWith(QLatin1Char('/')) {
    folder += QLatin1Char('/');
}

Does balooctl not need cross platform support?

I believe this explains why QDirSeparator should not be used here: http://agateau.com/2015/qdir-separator-considered-harmful/

Aug 23 2018, 2:58 PM · Baloo, Frameworks
jausmus added a comment to D15013: balootctl: fix 396535.

Do not use QDir::separator

if (!folder.endsWith(QLatin1Char('/')) {
    folder += QLatin1Char('/');
}
Aug 23 2018, 7:49 AM · Baloo, Frameworks
jausmus requested review of D15013: balootctl: fix 396535.
Aug 23 2018, 5:48 AM · Baloo, Frameworks