User Details
User Details
- User Since
- Aug 23 2018, 4:35 AM (297 w, 2 d)
- Availability
- Available
Aug 23 2018
Aug 23 2018
jausmus requested review of D15013: balootctl: fix 396535.
In D15013#314082, @bruns wrote:
- Use a proper commit message, with subject and body
- Please use "arc diff ..." to upload the diff, revisions without context are hard to review.
In D15013#313885, @mgallien wrote:In D15013#313880, @jausmus wrote:In D15013#313867, @anthonyfieroni wrote:Do not use QDir::separator
if (!folder.endsWith(QLatin1Char('/')) { folder += QLatin1Char('/'); }Does balooctl not need cross platform support?
I believe this explains why QDirSeparator should not be used here: http://agateau.com/2015/qdir-separator-considered-harmful/
In D15013#313867, @anthonyfieroni wrote:Do not use QDir::separator
if (!folder.endsWith(QLatin1Char('/')) { folder += QLatin1Char('/'); }