When calling QDir::remove the compiler cannot create a QString from a char literal. Using a string literal allows automatic conversion.
Details
Details
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Hi, thanks for your patch. Sorry for not noticing it earlier, we don't get a notification if you don't set Gwenview as either the reviewer or project tag.
As for the compilation issue, we discussed it in 73e0b8219c2c and it was fixed with 05a28a1838db. This means you can safely "abandon" your Diff with the Add Action button below.
Since you were working on Gwenview, let us know if you have any questions or need ideas for what to work on. There are still plenty of bugs left ;)
Comment Actions
Sounds like we need a Herald rule to automatically add a revelant mailing list or Phab group if no reviewers are specified. @bcooksley can probably take care of this.