| hindenburg | |
| sandsmark | |
| ngraham | |
| aacid |
| Konsole |
Add a new code for drag & drop that's non blocking.
Becuase of the usage of the QTabbar, a QDrag operation
would cause artifacts in the image because it would block
in the middle of a animation.
Fake the drag & drop operation using QMousePress/Move/Release.
The good thing is that the new code is smaller and easier to
understand than the old one, and it also fixes around 8 crashes.
Ready to Review.
Open konsole, create tabs, drag them, create new windows, reatach them, split the window in two, drag & drop between the split views.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 1938 | |
| Build 1956: arc lint + arc unit |
Also try to get the title of the commits to show the main subjects of the patch
Done.
- We still have the issue where newly created window's text is not visible until some other interaction.
Hm, this did not happened to me on the tests, I don't know why this is happening. I'm investigating.
Also try to get the title of the commits to show the main subjects of the patch
sorry, this is arc diff trying to be smart.
I think so, They are annoying to make because most of the code is event based, and faking mouse events is a pain.
I'll try to see what I can do.
Closing this review because I'm splitting this in many small reviews to ease the review request.