Fixes Tabbar Drag and Drop
AbandonedPublic

Authored by tcanabrava on Aug 4 2018, 12:09 PM.

Details

Reviewers
hindenburg
sandsmark
ngraham
aacid
Group Reviewers
Konsole
Summary

Add a new code for drag & drop that's non blocking.
Becuase of the usage of the QTabbar, a QDrag operation
would cause artifacts in the image because it would block
in the middle of a animation.

Fake the drag & drop operation using QMousePress/Move/Release.

The good thing is that the new code is smaller and easier to
understand than the old one, and it also fixes around 8 crashes.

Ready to Review.

Test Plan

Open konsole, create tabs, drag them, create new windows, reatach them, split the window in two, drag & drop between the split views.

Diff Detail

Repository
R319 Konsole
Branch
fixReataching
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1852
Build 1870: arc lint + arc unit
tcanabrava created this revision.Aug 4 2018, 12:09 PM
Restricted Application added a project: Konsole. · View Herald TranscriptAug 4 2018, 12:09 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Aug 4 2018, 12:09 PM
tcanabrava edited the summary of this revision. (Show Details)Aug 4 2018, 12:14 PM
tcanabrava edited the test plan for this revision. (Show Details)
  1. Don't allow a window that has only 1 tab to be DND out to create a new window with the same one tab
  2. We still have the issue where newly created window's text is not visible until some other interaction.

Also try to get the title of the commits to show the main subjects of the patch

  1. Don't allow a window that has only 1 tab to be DND out to create a new window with the same one tab

Done.

  1. We still have the issue where newly created window's text is not visible until some other interaction.

Hm, this did not happened to me on the tests, I don't know why this is happening. I'm investigating.

Also try to get the title of the commits to show the main subjects of the patch

sorry, this is arc diff trying to be smart.

tcanabrava updated this revision to Diff 39741.Aug 14 2018, 5:09 PM
tcanabrava edited the summary of this revision. (Show Details)
tcanabrava edited the test plan for this revision. (Show Details)
  • Inclide Cleanup
  • Forbid detaching with only one tab
  • Fix attaching in the correct split
  • Remove broken logic code.
  • Fix deataching, reataching, etc.
tcanabrava retitled this revision from Remove MimeType related code to Fixes Tabbar Drag and Drop.Aug 14 2018, 5:14 PM
  • Fix clicking in a tab to change current tab
  • Honor Settings: Add tab where user whants.

I have more things to send here, don’t review yet.

tcanabrava updated this revision to Diff 39904.Aug 17 2018, 9:46 AM
  • Fix Reataching logic (again)
  • Handle Closes
  • Fixes crashes related to closing tabs with splits
tcanabrava edited the summary of this revision. (Show Details)Aug 17 2018, 9:48 AM
tcanabrava edited the test plan for this revision. (Show Details)
tcanabrava added a reviewer: aacid.
aacid added a comment.Aug 18 2018, 9:22 PM

Can any of this be added to autotests?

Can any of this be added to autotests?

I think so, They are annoying to make because most of the code is event based, and faking mouse events is a pain.
I'll try to see what I can do.

tcanabrava abandoned this revision.Aug 22 2018, 10:27 AM

Closing this review because I'm splitting this in many small reviews to ease the review request.

Closing this review because I'm splitting this in many small reviews to ease the review request.

How's this going?

Finished. I just need to upload them, I'll do that today.