Can you add a screenshot?

In D14449#300086, @ngraham wrote:

Device capacity: 94.4 Gib
Device usage:    ==------ 24% full (71.9 GiB free, 22.5 GiB used)

That's much better. Another proposal built on top of that:

Device capacity: 94.4 Gib (22.5 GiB used, 71.9 GiB free)
                 ====---------- 24% full

(Does not duplicate "device", shorter for improved translatability, same units on the same line, order of used/free matches what the bar shows.)

Or perhaps there is a way to emphasize the most important information a bit more (IMO that's "71.9 GiB free")?

+1 for using the same label but putting the information on more than one line like @rkflx suggests.

I think there are basically three important pieces of information here:

• Percentage free (for people who don't understand what a "GiB" is--the "Simple by default" folks)
• Amount of free space left (for people who know what a GiB is and want hard numbers)
• Total disk capacity (for the above group of people)

The amount of space used is non-critical, which is probably why it wasn't displayed before, but I don't see the harm in adding it if we can avoid using too much horizontal space. Here's another idea for how to express everything while remaining compact in the horizontal dimension:

Device capacity: ====---------- 24% full
                 22.5 GiB used, 71.9 GiB free
                 94.4 Gib total size

In D14449#300327, @ngraham wrote:

Here's another idea for how to express everything while remaining compact in the horizontal dimension:

Device capacity: ====---------- 24% full
                 22.5 GiB used, 71.9 GiB free
                 94.4 Gib total size

Not bad at all, but due to using 3 lines now puts quite some emphasis on the device, while the dialog is about the folder actually. Would this be a compromise?:

Device capacity: ==----- 24% used of 94.4 Gib
                 22.5 GiB used, 71.9 GiB free

(Not too happy about the duplication of "used", though.)

We have other places where such information is displayed, e.g. the disk quota applet: https://kate-editor.org/2015/08/02/plasma-5-keeping-an-eye-on-the-disk-quota/
Maybe this is useful for input :)

I think it looks visually distracting that one progress bar line ends up in two lines of text - this should be avoided.

To behonest, the suggestion by @ngraham makes most sense to me: Two lines with the distinction of "Device capacity" and "Device usage".

Device capacity: 94.4 Gib
Device usage:    ==------ 24% full (71.9 GiB free, 22.5 GiB used)

Could you give this a try with screenshot?

In D14449#300841, @dhaumann wrote:

I think it looks visually distracting that one progress bar line ends up in two lines of text - this should be avoided.

To behonest, the suggestion by @ngraham makes most sense to me: Two lines with the distinction of "Device capacity" and "Device usage".

Device capacity: 94.4 Gib
Device usage:    ==------ 24% full (71.9 GiB free, 22.5 GiB used)

Could you give this a try with screenshot?

dhaumann: but that deviec capacity label seems to be redundant, because capacity is simply used + free

In D14449#300842, @shubham wrote:

dhaumann: but that deviec capacity label seems to be redundant, because capacity is simply used + free

Yeah, but you have to do mental math to calculate that. It doesn't make sense to make the user do math to find out how big their disk is.

Correct, but "visual cleanness" goes over redundancy (imo). In fact, the information 100 GiB, 20 GiB used (20%), 80 GiB free is also highly redundant.
So redundancy is not the argument here. Instead, I think we should follow the best visual design. And the progress bar + 2 lines text behind is clearly not visually the best solution :-)

no problem

In D14449#300841, @dhaumann wrote:

Device capacity: 94.4 Gib
Device usage:    ==------ 24% full (71.9 GiB free, 22.5 GiB used)

Could you give this a try with screenshot?

I'm afraid the second line will become too long for locales other than English, making the capacity bar a tiny dot. Try it in GammaRay (⇧+Ctrl click, then change the text, add some spacing in front which currently is missing).

Let me plug my suggestion again:

Device capacity: ==----- 24% used of 94.4 Gib
                 22.5 GiB used, 71.9 GiB free

@ngraham Any opinions on that?

@rkflx Would be fine with this, as long as the alignment is correct (i.e. the text "Device capacity: ==----- 24% used of 94.4 Gib" should all be one one line, and the text " 22.5 GiB used, 71.9 GiB free" should be below. The screenshot above is an example of wrong alignment.

In D14449#300868, @rkflx wrote:

Let me plug my suggestion again:

Device capacity: ==----- 24% used of 94.4 Gib
                 22.5 GiB used, 71.9 GiB free

@ngraham Any opinions on that?

I'm fine with that. A simple way to make sure the alignment is correct is to put all the strings that should be on a second line in their own cell in the gridView.

Device capacity: ==----- 24% used of 94.4 Gib
                 22.5 GiB used, 71.9 GiB free

if this design is used , then the capacity bar would look elongated and stretched, which doesn't looks good. (above screen shot)
Since used space is not of that much importance, so we can just omit it like this
Device capacity: =======> 24% full of 90GiB (70GiB free)

In D14449#303660, @shubham wrote:

Let me plug my suggestion again:

Device capacity: ==----- 24% used of 94.4 Gib
                 22.5 GiB used, 71.9 GiB free

if this design is used , then the capacity bar would look elongated and stretched, which doesn't looks good.

Not if you set a maximum width.

Since used space is not of that much importance, so we can just omit it like this
Device capacity: =======> 24% full of 90GiB (70GiB free)

That's more or less what we currently have without your patch, but if we want to close the bug as WONTFIX I'd prefer the original order.

Not if you set a maximum width.

@rkflx eeh, skipped from my mind
btw , then it is doable

This comment has been deleted.

You are doing this in every other Diff, which is a bit annoying. Please first check what you wrote, then click on Send. Otherwise people will just ignore notifications.

is there any other simpler way to achieve this?

Maybe, maybe not. I added my idea on that topic above, but it's not my job to research that in depth.

In D14449#300327, @ngraham wrote:

+1 for using the same label but putting the information on more than one line like @rkflx suggests.

sorry for causing trouble : (

In D14449#303766, @shubham wrote:

In D14449#300327, @ngraham wrote:

+1 for using the same label but putting the information on more than one line like @rkflx suggests.

As far as I can see that comment was part of the discussion about what to show, which I think we now concluded. I don't think that was meant as an advice regarding implementation.

You are already creating a new label (which is fine, also where you're doing it is the perfect spot). I was only wondering whether the call to setText should better be placed elsewhere.

Do you plan to submit a new version of this after the layout has been converted to use QFormLayout? I do hope some form of this patch makes it in, since IMHO it's a nice little quality-of-life improvement.

Great! Are you gonna do the QFormLayout patch, or should I?

You plz proceed on it. Right now working on some other patch.

won't the pie chart representation look good, as we have in windows?

A pie chart could work. But is there something wrong with the current representation?

In D14449#335788, @shubham wrote:

won't the pie chart representation look good, as we have in windows?

That would be way too much wasted space for eye candy.