It's just not overloaded by QStringList, so we keep a local definition here.
Details
Details
tests still pass, discover still runs.
Diff Detail
Diff Detail
- Repository
- R235 Attica
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Does this really make a difference?
Also... fix qt to get QStringList::containst(QStringRef)?
Comment Actions
I was looking at heaptrack and this function was a point of contention, maybe not a big deal.
Also... fix qt to get QStringList::containst(QStringRef)?
Last time I submitted a QStringRef overload to Qt, QStringView-man told me it was the wrong thing to do and he had everything figured out. I can do it though.
src/parser.cpp | ||
---|---|---|
58 | You could also use if (std::any_of(elements.begin(), elements.end(), [&xml](const auto& e) { return e == xml.name(); }) { |