Differential D14160

[KMessageBox] Call style for icon
ClosedPublic
Actions

Authored by broulik on Jul 16 2018, 3:41 PM.

Details

Reviewers
dfaure
kfunk
dhaumann
Commits
R236:c6be3760ecd0: [KMessageBox] Call style for icon
Summary

QMessageBox::standardIcon is deprecated. Also, both QCommonStyle does exactly what we do here, and so does KStyle.

Test Plan

Tests still pass. Dialog icons are correct on Linux with Breeze, Fusion, and Windows 95 style.
This needs testing on Windows and Mac as there it might use the system-provided graphics now?

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 16 2018, 3:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 16 2018, 3:41 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 16 2018, 3:41 PM
dhaumann accepted this revision.Jul 16 2018, 8:42 PM
dhaumann added a subscriber: dhaumann.

In general, looks good to me.

This revision is now accepted and ready to land.Jul 16 2018, 8:42 PM
rkflx added a subscriber: rkflx.Jul 17 2018, 11:52 PM

Dialog icons are correct on Linux with Breeze

…if you also apply D14161. Otherwise LGTM.

This needs testing on Windows and Mac

You could add or ping more reviewers who happen to have a dev setup on those platforms, perhaps Elisa?

Closed by commit R236:c6be3760ecd0: [KMessageBox] Call style for icon (authored by broulik). · Explain WhyAug 8 2018, 7:31 AM
This revision was automatically updated to reflect the committed changes.
broulik mentioned this in R252:baf011a72ffc: [KStyle] Use dialog-question for question icon.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagebox.cpp (53 lines)

Diff 39288

View Options

src/kmessagebox.cpp

Loading...