Use Breeze's new broom-style icon for the Clear History buttons in the Klipper and Notification plasmoids.
Details
Details
- Reviewers
broulik Fuchs davidedmundson - Group Reviewers
Plasma - Commits
- R120:ad9ec635bed1: Use a broom-style icon for clearing clipboard and notification history
With Frameworks 5.48, the broom-style icon will be shown:
With an earlier Frameworks version or a different icon theme, a backspace-style icon will be displayed:
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- broom-style-clear-history-icon (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 840 Build 853: arc lint + arc unit
Comment Actions
Can't test it currently, looks fine, just one question: did you test what happens on other icon sets than breeze?
If that doesn't work, I'd say we should fix it in the icon theme, but that would be something that would make me think don't ship yet.
Otherwise I'd say ship :)
This comment was removed by ngraham.
Comment Actions
Right, it's not a problem:
- Either the theme has its own version of that icon (as Oxygen does)
- ...Or else the theme symlinks that icon to something else (as Papirus does; it's symlinked to edit-clear which looks like the backspace symbol)...
- ...Or else it falls back to the Breeze icon (which in 5.48 is a broom, and prior to 5.48 looks like the backspace symbol)
Comment Actions
Can you share the svg file for this icon please? I would like to edit it a little bit
Comment Actions
<teach-a-man-to-fish-mode>Check out https://community.kde.org/Get_Involved/development#Get_the_code :)</teach-a-man-to-fish-mode>