Differential D13970

Handle empty preview lists
ClosedPublic
Actions

Authored by cordlandwehr on Jul 8 2018, 4:29 PM.

Details

Reviewers
dhaumann
Commits
R304:c4275aaf79fc: Handle empty preview lists
Summary

Do not access the first list's element if the list possibly
might be empty.

Diff Detail

Repository
R304 KNewStuff
Branch
bugfix/allowEmptyPreviewLists
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 677
Build 689: arc lint + arc unit
cordlandwehr created this revision.Jul 8 2018, 4:29 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 8 2018, 4:29 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cordlandwehr requested review of this revision.Jul 8 2018, 4:29 PM
dhaumann added a comment.Jul 8 2018, 7:56 PM

Which bug in which context does this fix? The information given is a bit 'thin' ;-)

gregormi added a comment.Jul 8 2018, 8:27 PM

I am rather familiar with KMoreTools but not with the rest of KNewStuff.

dhaumann accepted this revision.Jul 8 2018, 8:30 PM

In any case, this patch will not break things.

This revision is now accepted and ready to land.Jul 8 2018, 8:30 PM
cordlandwehr removed reviewers: gregormi, nicolasfella, dhaumann, Frameworks.Jul 8 2018, 8:32 PM

I had a crash at the respective locations while porting Artikulate to the QtQuick based API, since those KNS resource files do not provide previews.
However, IMO this patch fixes an unsafe access to a list element without checking that it exists.

This revision now requires review to proceed.Jul 8 2018, 8:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2018, 4:43 PM
Closed by commit R304:c4275aaf79fc: Handle empty preview lists (authored by cordlandwehr). · Explain Why
This revision was automatically updated to reflect the committed changes.
cordlandwehr added a reviewer: dhaumann.Jul 12 2018, 4:45 PM

Somehow removed all reviewers with my last message (sorry!)
Trying to fix this now.

Revision Contents
Changeset List

PathPackages
Msrc/qtquick/quickitemsmodel.cpp (4 lines)

Diff 37345

View Options

src/qtquick/quickitemsmodel.cpp

Loading...