The widget is "semi-transparent" by mixing in window background color but wouldn't update it when the color changed at runtime.
Details
Details
- Reviewers
rjvbb ngraham cfeck - Group Reviewers
Frameworks - Commits
- R236:ea282678c937: [KMessageWidget] Update stylesheet when palette changes
Changed system colors, message widget look changed immediately
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Otherwise LGTM (I also checked the in-app palette change myself: seems to work fine).
src/kmessagewidget.cpp | ||
---|---|---|
57 | Nitpick: shouldn't this be called setStyleSheet or something similar that indicates a bit better that it defines the stylesheet itself? |
src/kmessagewidget.cpp | ||
---|---|---|
57 | It doesn't take any arguments, so I explicitly did not call it set |