Differential D13884

[KMessageWidget] Update stylesheet when palette changes
ClosedPublic
Actions

Authored by broulik on Jul 4 2018, 1:36 PM.

Details

Reviewers
rjvbb
ngraham
cfeck
Group Reviewers
Frameworks
Commits
R236:ea282678c937: [KMessageWidget] Update stylesheet when palette changes
Summary

The widget is "semi-transparent" by mixing in window background color but wouldn't update it when the color changed at runtime.

Test Plan

Changed system colors, message widget look changed immediately

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 4 2018, 1:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 4 2018, 1:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 4 2018, 1:36 PM
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
broulik updated this revision to Diff 37144.Jul 4 2018, 1:44 PM
  • Juggle it around a bit
rjvbb added a comment.Jul 4 2018, 2:17 PM

Otherwise LGTM (I also checked the in-app palette change myself: seems to work fine).

src/kmessagewidget.cpp
57

Nitpick: shouldn't this be called setStyleSheet or something similar that indicates a bit better that it defines the stylesheet itself?

rjvbb accepted this revision.Jul 4 2018, 2:17 PM
This revision is now accepted and ready to land.Jul 4 2018, 2:17 PM
ngraham accepted this revision.Jul 4 2018, 2:28 PM

Thanks, works as expected and I couldn't find any regressions. Code looks good.

broulik added inline comments.Jul 5 2018, 7:33 AM
src/kmessagewidget.cpp
57

It doesn't take any arguments, so I explicitly did not call it set

dhaumann added a subscriber: dhaumann.Jul 6 2018, 6:08 AM

Late to the game, but also +1 from me.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagewidget.cpp (106 lines)

Diff 37144

View Options

src/kmessagewidget.cpp

Loading...