To explicitly confine Task Manager drops to Plasma and avoid accidental
drops on other apps, D13274 makes it store task launcher URLs in a special
internal MIME type instead of the generic text/url one. This change to
processMimeData() adds the necessary conversion back.
Details
Details
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hmm, this doesn't build for me (Neon dev unstable, deps built from source):
/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp: In member function 'void ContainmentInterface::processMimeData(QMimeData*, int, int, KIO::DropJob*)':
/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:455:52: error: 'mimeCopy' was not declared in this scope
QList<QUrl> urls = {QUrl(QString::fromUtf8(mimeCopy->data(QStringLiteral("text/x-orgkd
^
/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:455:126: error: could not convert '{<expression error>}' from '<brace-enclosed initializer list>' to 'QList<QUrl>'
QString::fromUtf8(mimeCopy->data(QStringLiteral("text/x-orgkdeplasmataskmanager_taskurl"))))};