Adds a checkbox and changes the filter of the ListView models.
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Branch
- arcpatch-D13243
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17073 Build 17091: arc lint + arc unit
I have a "module-null-sink" loaded at all times. I use it to record from via OBS, so I can selectively record Desktop Audio. (This is coupled with a "module-loopback" so I can hear the Null Sink with my headset, too). Of course I need to manually set application streams to point to my null sink. I always do this with pavucontrol. It would be more convenient though, if I could just use the PA applet as it has the nice drag and drop feature there.
As this new behaviour is disabled by default it should not impact those who don't need this.
applet/contents/ui/ConfigGeneral.qml | ||
---|---|---|
89 | This isn't a feedback-related item so it shouldn't be in the Feedback section. I would do it more like this: Item { Kirigami.FormData.isSection: true } QQC2.CheckBox { id: showRealDevicesOnly Kirigami.FormData.label: i18n("Show:") text: i18n("Virtual audio streams and devices") } |
I think Nate's idea on how to display this in the applet config is better. Will do that instead
Seems sane enough to me. Even though it's a new esoteric option, it does seem useful for certain use cases and it's buried in a config window that almost nobody will ever see, so I think it's all right.
Plasma folks, any comments or objections?
Now that I think about this some more, might it make sense to have the option in the KCM, and then checking it would show virtual streams in both the applet and the KCM? Otherwise it might be a bit odd to have this apply only to the applet.
I could not find the time to work on this yet. Generally I like the idea. We could then also make the volume step configuration global instead of putting that into the applet, which is currently weird, too. I guess the plasma-pa KCM's Advanced tab would be suitable for these options. How could we expose the values of the KCM to the applet though?
Oh that's the easy part. Check out the code in KScreen to see how it's possible to export values under a "kcm" namespace.