[applet] Add checkbox to show virtual streams
AcceptedPublic

Authored by sefaeyeoglu on May 31 2018, 6:18 PM.

Details

Reviewers
drosca
ngraham
Group Reviewers
Plasma
VDG
Summary

Adds a checkbox and changes the filter of the ListView models.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
arcpatch-D13243
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17091
Build 17109: arc lint + arc unit
sefaeyeoglu created this revision.May 31 2018, 6:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 31 2018, 6:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sefaeyeoglu requested review of this revision.May 31 2018, 6:18 PM
ngraham added a subscriber: ngraham.

Yikes, looks like this never went anywhere. :/

Can you rebase it?

Yikes, looks like this never went anywhere. :/

Can you rebase it?

I actually don't remember ever making this but of course I can :D

Rebase onto master

Add copyright header

sefaeyeoglu added a comment.EditedSep 26 2019, 10:08 PM

What's the use case?

I have a "module-null-sink" loaded at all times. I use it to record from via OBS, so I can selectively record Desktop Audio. (This is coupled with a "module-loopback" so I can hear the Null Sink with my headset, too). Of course I need to manually set application streams to point to my null sink. I always do this with pavucontrol. It would be more convenient though, if I could just use the PA applet as it has the nice drag and drop feature there.

As this new behaviour is disabled by default it should not impact those who don't need this.

ngraham requested changes to this revision.Sep 27 2019, 2:15 PM
ngraham added inline comments.
applet/contents/ui/ConfigGeneral.qml
89

This isn't a feedback-related item so it shouldn't be in the Feedback section. I would do it more like this:

Item {
    Kirigami.FormData.isSection: true
}

QQC2.CheckBox {
    id: showRealDevicesOnly
    Kirigami.FormData.label: i18n("Show:")
    text: i18n("Virtual audio streams and devices")
}
This revision now requires changes to proceed.Sep 27 2019, 2:15 PM
sefaeyeoglu updated this revision to Diff 66951.EditedSep 27 2019, 2:27 PM

Put checkbox into own category

I think Nate's idea on how to display this in the applet config is better. Will do that instead

sefaeyeoglu updated this revision to Diff 66952.EditedSep 27 2019, 2:37 PM

Change behaviour of configuration.

ngraham accepted this revision.Sep 27 2019, 2:57 PM

Seems sane enough to me. Even though it's a new esoteric option, it does seem useful for certain use cases and it's buried in a config window that almost nobody will ever see, so I think it's all right.

Plasma folks, any comments or objections?

This revision is now accepted and ready to land.Sep 27 2019, 2:57 PM
sefaeyeoglu marked an inline comment as done.Sep 28 2019, 10:45 AM
baberts added a subscriber: baberts.
ngraham retitled this revision from Add checkbox that can show virtual streams in the applet. to [applet] Add checkbox to show virtual streams.Tue, Oct 15, 8:36 PM

Now that I think about this some more, might it make sense to have the option in the KCM, and then checking it would show virtual streams in both the applet and the KCM? Otherwise it might be a bit odd to have this apply only to the applet.