With iconFromDirectoryFile() a public function thanks to D13082, we can use it to get custom icons for folders.
BUG: 356045
FIXED-IN: 5.47
apol | |
broulik | |
dfaure |
Frameworks |
With iconFromDirectoryFile() a public function thanks to D13082, we can use it to get custom icons for folders.
BUG: 356045
FIXED-IN: 5.47
No Linters Available |
No Unit Test Coverage |
This still has the issue of blocking if the contents is an unavailable nfs share of some sort.
src/core/global.cpp | ||
---|---|---|
385 | You do toLocalFile() here, so move that also into the isLocalFile() branch |
Unlike KFileItem, this function does no caching. I hope you do caching at the layer above then...
To skip this for NFS/SMB shares you need code like the one in KFileItemPrivate::isSlow().
So maybe we should go back to using KFileItem like I had clumsily tried to do in D13048, and just ensure that we don't even try to go down this codepath for remote folders. Does that seem like a better approach?