Differential D13082

Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore
AbandonedPublic
Actions

Authored by ngraham on May 23 2018, 11:08 PM.

Details

Reviewers
apol
dfaure
Group Reviewers
Frameworks
Summary

This allows us to use them in KIO::iconNameForURL() to gain custom folder icon support.

CCBUG: 356045

Test Plan
  • No visual regressions in Dolphin
  • No unit test regressions

Diff Detail

Repository
R241 KIO
Branch
public-iconFromDesktopFile-and-iconFromDirectoryFile (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.May 23 2018, 11:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 23 2018, 11:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.May 23 2018, 11:08 PM
broulik added a subscriber: broulik.May 24 2018, 7:35 AM

Imho fine in principle, but:
QFileInfo stats internally and KDesktopFile actually reads file contents. I don't see how you came to the conclusion this doesn't stat.

ngraham added a comment.May 24 2018, 1:01 PM

Hmm, you're right. I guess there's no way around that if we want custom icon support here...

ngraham edited the summary of this revision. (Show Details)May 24 2018, 1:02 PM
ngraham added a comment.Jun 25 2019, 3:22 PM

Abandoning in favor of D13048

ngraham abandoned this revision.Jun 25 2019, 8:55 PM

Revision Contents
Changeset List

PathPackages
Msrc/core/global.h (25 lines)
Msrc/core/global.cpp (62 lines)
Msrc/core/kfileitem.cpp (64 lines)

Diff 34762

View Options

src/core/global.h

Loading...
View Options

src/core/global.cpp

Loading...
View Options

src/core/kfileitem.cpp

Loading...