Differential D12619

[effects/presentwindows] Enable blur behind windows
ClosedPublic
Actions

Authored by anemeth on Apr 30 2018, 6:28 PM.

Details

Reviewers
davidedmundson
fredrik
graesslin
ngraham
Group Reviewers
VDG
KWin
Commits
R108:424b9ac388b9: [effects/presentwindows] Enable blur behind windows
Summary

Use the blur effect even when the present windows is used.
Previously it was only enabled for the close buttons and the dock.

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anemeth created this revision.Apr 30 2018, 6:28 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 30 2018, 6:28 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
anemeth requested review of this revision.Apr 30 2018, 6:28 PM
anemeth edited the summary of this revision. (Show Details)Apr 30 2018, 6:31 PM
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: davidedmundson, fredrik.
anemeth added a reviewer: VDG.
zzag added a subscriber: zzag.Apr 30 2018, 7:25 PM

Please, rename title because it's misleading.

anemeth added a comment.Apr 30 2018, 7:27 PM
In D12619#256129, @zzag wrote:

Please, rename title because it's misleading.

What do you mean misleading? I don't see anything wrong with it.
What do you suggest instead?

zzag added a comment.Apr 30 2018, 7:37 PM
In D12619#256131, @anemeth wrote:

What do you mean misleading? I don't see anything wrong with it.

Well, I thought it was about blurring background like in Mission Control (Yosemite).

What do you suggest instead?

"[effects/presentwindows] Force blur behind windows", something like that.

ngraham added a subscriber: ngraham.Apr 30 2018, 7:42 PM
In D12619#256133, @zzag wrote:
In D12619#256131, @anemeth wrote:

What do you mean misleading? I don't see anything wrong with it.

Well, I thought it was about blurring background like in Mission Control (Yosemite).

What do you suggest instead?

"[effects/presentwindows] Force blur behind windows", something like that.

That's not what this appears to be, though. Take a look at the video.

anemeth retitled this revision from Enable blur for present windows effect to [effects/presentwindows] Enable blur behind windows.Apr 30 2018, 7:58 PM
zzag added a comment.Apr 30 2018, 9:00 PM

Also, you may want to force background contrast.

graesslin accepted this revision.May 1 2018, 9:23 AM
This revision is now accepted and ready to land.May 1 2018, 9:23 AM
anemeth edited the summary of this revision. (Show Details)May 1 2018, 3:39 PM
ngraham accepted this revision.May 1 2018, 3:41 PM

Have you gotten your developer account yet? :)

anemeth added a comment.May 1 2018, 3:43 PM
In D12619#256489, @ngraham wrote:

Have you gotten your developer account yet? :)

Yep! Just a day ago.

ngraham added a comment.May 1 2018, 3:44 PM

Excellent. :)

Closed by commit R108:424b9ac388b9: [effects/presentwindows] Enable blur behind windows (authored by anemeth). · Explain WhyMay 1 2018, 8:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33454

View Options

effects/presentwindows/presentwindows.h

Loading...
View Options

effects/presentwindows/presentwindows.cpp

Loading...