Differential D12596

DatabaseInterface: replace lots of signal ArtistAdded by one ArtistsAdded
ClosedPublic
Actions

Authored by mgallien on Apr 29 2018, 7:16 AM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Maniphest Tasks

T7603: When scanning local files, keep their last modified time and do not scan them again if they have not changed

Commits

R255:a791467e800a: DatabaseInterface: replace lots of signal ArtistAdded by one ArtistsAdded

Summary

DatabaseInterface: replace lots of signal ArtistAdded by one ArtistsAdded

should help make database reload faster on startup

Test Plan

Elisa works and the automatic tests are OK

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Apr 29 2018, 7:16 AM

mgallien created this revision.

mgallien added a task: T7603: When scanning local files, keep their last modified time and do not scan them again if they have not changed.Apr 29 2018, 7:17 AM

rebase on master

mgallien added a dependent revision: D12609: remove DatabaseInterface::trackAdded signals to improve performance.Apr 30 2018, 9:25 AM

astippich accepted this revision.May 1 2018, 7:57 AM

This revision is now accepted and ready to land.May 1 2018, 7:57 AM

Closed by commit R255:a791467e800a: DatabaseInterface: replace lots of signal ArtistAdded by one ArtistsAdded (authored by mgallien). · Explain WhyMay 1 2018, 12:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/allartistsmodeltest.cpp (30 lines)
M			autotests/databaseinterfacetest.cpp (164 lines)
M			src/databaseinterface.h (17 lines)
M			src/databaseinterface.cpp (94 lines)
M			src/main.cpp (1 line)
M			src/models/allartistsmodel.h (2 lines)
M			src/models/allartistsmodel.cpp (8 lines)
M			src/musiclistenersmanager.h (2 lines)
M			src/musiclistenersmanager.cpp (8 lines)

Diff 33386

autotests/allartistsmodeltest.cpp

Loading...

autotests/databaseinterfacetest.cpp

Loading...

src/databaseinterface.h

Loading...

src/databaseinterface.cpp

Loading...

src/main.cpp

Loading...

src/models/allartistsmodel.h

Loading...

src/models/allartistsmodel.cpp

Loading...

src/musiclistenersmanager.h

Loading...

src/musiclistenersmanager.cpp

Loading...