Differential D12609

remove DatabaseInterface::trackAdded signals to improve performance
ClosedPublic
Actions

Authored by mgallien on Apr 30 2018, 9:22 AM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Maniphest Tasks

T7603: When scanning local files, keep their last modified time and do not scan them again if they have not changed

Commits

R255:55f4f92404a7: remove DatabaseInterface::trackAdded signals to improve performance

Summary

remove DatabaseInterface::trackAdded signals to improve performance

should help make startup and indexing faster

in preparation for optimisation of init when tracks are already known

Test Plan

tests are OK

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Apr 30 2018, 9:22 AM

mgallien created this revision.

mgallien added a task: T7603: When scanning local files, keep their last modified time and do not scan them again if they have not changed.Apr 30 2018, 9:25 AM

mgallien added a dependency: D12596: DatabaseInterface: replace lots of signal ArtistAdded by one ArtistsAdded.

mgallien added a dependent revision: D12622: start to store the modification time for files in the database.Apr 30 2018, 8:10 PM

astippich accepted this revision.May 1 2018, 8:47 AM

This revision is now accepted and ready to land.May 1 2018, 8:47 AM

Closed by commit R255:55f4f92404a7: remove DatabaseInterface::trackAdded signals to improve performance (authored by mgallien). · Explain WhyMay 1 2018, 12:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/databaseinterfacetest.cpp (237 lines)
M			src/databaseinterface.h (2 lines)
M			src/databaseinterface.cpp (25 lines)
M			src/musiclistenersmanager.h (2 lines)
M			src/musiclistenersmanager.cpp (2 lines)

Diff 33387

autotests/databaseinterfacetest.cpp

Loading...

src/databaseinterface.h

Loading...

src/databaseinterface.cpp

Loading...

src/musiclistenersmanager.h

Loading...

src/musiclistenersmanager.cpp

Loading...