Details

In D12622#256293, @astippich wrote:

The fileTime function was only introduced in Qt 5.10 according to docs, so it fails here (still 5.9). Maybe it's time to bump the requirement?

Thanks for noticing the problem. As for the version bump, I am not sure we can. I have to ask if the KDE continuous integration can provide this version.

rebase on top of master

In D12622#256306, @mgallien wrote:

In D12622#256293, @astippich wrote:

The fileTime function was only introduced in Qt 5.10 according to docs, so it fails here (still 5.9). Maybe it's time to bump the requirement?

Thanks for noticing the problem. As for the version bump, I am not sure we can. I have to ask if the KDE continuous integration can provide this version.

The build.kde.org CI KDE service is now using only Qt 5.10 and the binary-factory.kde.org was already using it. The flatpak service will soon use Qt 5.10 (pending D12673).
We are ready to bump the requirement to Qt 5.10.

@astippich Is it fine for you ?

In D12622#257446, @mgallien wrote:

In D12622#256306, @mgallien wrote:

In D12622#256293, @astippich wrote:

The fileTime function was only introduced in Qt 5.10 according to docs, so it fails here (still 5.9). Maybe it's time to bump the requirement?

Thanks for noticing the problem. As for the version bump, I am not sure we can. I have to ask if the KDE continuous integration can provide this version.

The build.kde.org CI KDE service is now using only Qt 5.10 and the binary-factory.kde.org was already using it. The flatpak service will soon use Qt 5.10 (pending D12673).
We are ready to bump the requirement to Qt 5.10.

@astippich Is it fine for you ?

go ahead, time to update my computer

require Qt v5.10.0

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2018, 8:46 PM

Closed by commit R255:2b4adb38b3d4: start to store the modification time for files in the database (authored by mgallien). · Explain Why

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/albummodeltest.cpp (57 lines)
M			autotests/allalbumsmodeltest.cpp (51 lines)
M			autotests/allartistsmodeltest.cpp (47 lines)
M			autotests/alltracksmodeltest.cpp (60 lines)
M			autotests/alltracksproxymodeltest.cpp (58 lines)
M			autotests/databaseinterfacetest.cpp (127 lines)
M			autotests/localfilelistingtest.cpp (46 lines)
M			autotests/manageheaderbartest.h (46 lines)
M			autotests/managemediaplayercontroltest.h (46 lines)
M			autotests/mediaplaylisttest.h (46 lines)
M			autotests/trackslistenertest.cpp (47 lines)
M			src/baloo/localbaloofilelisting.cpp (2 lines)
M			src/databaseinterface.h (4 lines)
M			src/databaseinterface.cpp (83 lines)
M			src/elisautils.cpp (14 lines)
M			src/musicaudiotrack.h (8 lines)
M			src/musicaudiotrack.cpp (28 lines)
M			src/musiclistenersmanager.h (16 lines)
M			src/musiclistenersmanager.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33360	d76ec57		Apr 30 2018, 7:58 PM	★	★
Diff 2	33388	55f4f92	rebase on top of master	May 1 2018, 12:30 PM	★	★
Diff 3	33437	9a7d8e2	rebase on top of master	May 1 2018, 8:05 PM	★	★
Diff 4	33577	8de49da	- require Qt v5.10.0	May 3 2018, 8:46 PM	★	★
Diff 5	33578	8de49da	R255:2b4adb38b3d434b56086b9d1f94b98c6706dcf32	May 3 2018, 8:46 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fe66776f27f8	6e8a3b1e4ed8	e35634190c22	Matthieu Gallien	require Qt v5.10.0	May 3 2018, 8:45 PM
e35634190c22	de941e67dc8c	8de49da0a856	Matthieu Gallien	start to store the modification time for files in the database (Show More…)	Apr 30 2018, 7:56 PM

start to store the modification time for files in the database
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 33578

CMakeLists.txt

autotests/albummodeltest.cpp

autotests/allalbumsmodeltest.cpp

autotests/allartistsmodeltest.cpp

autotests/alltracksmodeltest.cpp

autotests/alltracksproxymodeltest.cpp

autotests/databaseinterfacetest.cpp

autotests/localfilelistingtest.cpp

autotests/manageheaderbartest.h

autotests/managemediaplayercontroltest.h

autotests/mediaplaylisttest.h

autotests/trackslistenertest.cpp

src/baloo/localbaloofilelisting.cpp

src/databaseinterface.h

src/databaseinterface.cpp

src/elisautils.cpp

src/musicaudiotrack.h

src/musicaudiotrack.cpp

src/musiclistenersmanager.h

src/musiclistenersmanager.cpp

start to store the modification time for files in the databaseClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 33578

CMakeLists.txt

autotests/albummodeltest.cpp

autotests/allalbumsmodeltest.cpp

autotests/allartistsmodeltest.cpp

autotests/alltracksmodeltest.cpp

autotests/alltracksproxymodeltest.cpp

autotests/databaseinterfacetest.cpp

autotests/localfilelistingtest.cpp

autotests/manageheaderbartest.h

autotests/managemediaplayercontroltest.h

autotests/mediaplaylisttest.h

autotests/trackslistenertest.cpp

src/baloo/localbaloofilelisting.cpp

src/databaseinterface.h

src/databaseinterface.cpp

src/elisautils.cpp

src/musicaudiotrack.h

src/musicaudiotrack.cpp

src/musiclistenersmanager.h

src/musiclistenersmanager.cpp

start to store the modification time for files in the database
ClosedPublic
Actions

Revision Contents
Changeset List