start to store the modification time for files in the database
ClosedPublic

Authored by mgallien on Apr 30 2018, 7:58 PM.

Details

Summary

start to store the modification time for files in the database

this allows to scan files again only if they have a modification time greater than the one stored in database

Test Plan

tests are OK

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Apr 30 2018, 7:58 PM
mgallien created this revision.
astippich requested changes to this revision.May 1 2018, 8:47 AM
astippich added a subscriber: astippich.

The fileTime function was only introduced in Qt 5.10 according to docs, so it fails here (still 5.9). Maybe it's time to bump the requirement?

This revision now requires changes to proceed.May 1 2018, 8:47 AM

The fileTime function was only introduced in Qt 5.10 according to docs, so it fails here (still 5.9). Maybe it's time to bump the requirement?

Thanks for noticing the problem. As for the version bump, I am not sure we can. I have to ask if the KDE continuous integration can provide this version.

mgallien updated this revision to Diff 33388.May 1 2018, 12:30 PM

rebase on top of master

mgallien updated this revision to Diff 33437.May 1 2018, 8:05 PM

rebase on top of master

mgallien added a comment.EditedMay 2 2018, 8:45 PM

The fileTime function was only introduced in Qt 5.10 according to docs, so it fails here (still 5.9). Maybe it's time to bump the requirement?

Thanks for noticing the problem. As for the version bump, I am not sure we can. I have to ask if the KDE continuous integration can provide this version.

The build.kde.org CI KDE service is now using only Qt 5.10 and the binary-factory.kde.org was already using it. The flatpak service will soon use Qt 5.10 (pending D12673).
We are ready to bump the requirement to Qt 5.10.

@astippich Is it fine for you ?

The fileTime function was only introduced in Qt 5.10 according to docs, so it fails here (still 5.9). Maybe it's time to bump the requirement?

Thanks for noticing the problem. As for the version bump, I am not sure we can. I have to ask if the KDE continuous integration can provide this version.

The build.kde.org CI KDE service is now using only Qt 5.10 and the binary-factory.kde.org was already using it. The flatpak service will soon use Qt 5.10 (pending D12673).
We are ready to bump the requirement to Qt 5.10.

@astippich Is it fine for you ?

go ahead, time to update my computer

mgallien updated this revision to Diff 33577.May 3 2018, 8:46 PM
  • require Qt v5.10.0
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2018, 8:46 PM
This revision was automatically updated to reflect the committed changes.