| elvisangelaccio |
| Frameworks | |
| Dolphin |
This patch uses a regular-style dialog instead of a list-style dialog when the user is trying to trash or delete only a single item. It looks a bit nicer than showing a dialog that has a list with only a single item in it.
Also change the string "Trash" to "Move to Trash", to prevent ambiguity in languages where the word can be either a noun or a verb.
Depends on D12420
Made sure that trash and deletion operations all still work. Here's how it looks:
Delete a single file:
Delete multiple files:
Trash a single file:
Trash multiple files:
| No Linters Available |
| No Unit Test Coverage |
Move the warnings to their own line so they're not missed, and also to improve the presentation
I agree it looks nicer, but the actual file that is being deleted now is somewhat hidden in a text. I think it's the most important information the user wants to read (did I select the right file for deletion?). Could the file be made more prominent, e.g. starting at a new line, or bold, or italic or whatever?
Maybe even mimic the old list but not using a separate widget:
Do you really want to move this item to the trash?
/my/path/file.txt
<b>Warning blabla</b>
Move to Trash | Cancel
| src/widgets/jobuidelegate.cpp | ||
|---|---|---|
| 230 | %1? -> %1 | |
| src/widgets/jobuidelegate.cpp | ||
|---|---|---|
| 230 | Please wrap %1 with the <filename> tag | |
| src/widgets/jobuidelegate.cpp | ||
|---|---|---|
| 253 | Please also mention this change in the commit message. | |