Delete a single file:
Delete multiple files:
Empty the trash:
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Frameworks Dolphin - Commits
- R241:96ba810b3964: Make the warning text for deletion operations emphasize its permanency and…
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- more-serious-delete-text (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Move the warnings to their own line so they're not missed, and also to improve the presentation
| src/widgets/jobuidelegate.cpp | ||
|---|---|---|
| 229 | Please use semantic markup and the <nl/> tag instead of \n, see https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup | |
| src/widgets/jobuidelegate.cpp | ||
|---|---|---|
| 229 | Couldn't get <nl/> working, so I hope <p> tags are okay. | |
| src/widgets/jobuidelegate.cpp | ||
|---|---|---|
| 229 | Nope, see the following warnings: "Tag 'p' is not defined in message {<__kuit_internal_top__><p>Do you really want to permanently delete this item?</p...}."
"Tag 'p' is not defined in message {<__kuit_internal_top__><p>Do you really want to permanently delete this item?</p...}."
"Tag 'b' is not defined in message {<__kuit_internal_top__><p>Do you really want to permanently delete this item?</p...}."What we need is to use xi18ncp() with @info as context, <nl/> instead of <p></p> and <emphasis strong='true'></emphasis> instead of <b></b>. | |
Comment Actions
- We already have the sentence "This action cannot be undone" in the empty trash dialog alongside the word "permanently". This patch just makes the similarly destructive delete action say the same thing.
- It's well known that users barely read this kind of text, if at all. They only tend to remember parts of the text that are at the beginning or end, and the word "permanently" is buried in the middle. Regardless, I think the extra sentence "This action cannot be undone" is important to emphasize. This is an irreversible destructive action, after all.
- The purpose of making the text bold was to draw the casual user's eye to it and make them remember it. If there's anything about this dialog that we want them to remember, it's that they can't undo it and are on their own if they make a mistake.
Comment Actions
Besides, people like you (and me) who find this kind of hand-holding annoying can (and likely do) just check the checkbox for "Do not ask again". Problem solved.
Comment Actions
How about adding "Permanently" to the action button?
And no I don't want to turn off confirmation for deleting files.
makes the similarly destructive delete action say the same thing.
I see. It's not bold, though.
Comment Actions
Looking at it again, I think you convinved me. Just mind the string freeze (two weeks before tag), push it only after the upcoming Frameworks tag.
Comment Actions
Thanks Kai! I'll wait until after tagging to land it, assuming @elvisangelaccio is satisfied by that point.
Comment Actions
I liked more the version with two newlines before the bold sentence, is there a reason why you changed to only one?
| src/widgets/jobuidelegate.cpp | ||
|---|---|---|
| 239 | There is a missing slash in the <nl> tag. | |